declare gltf-loader-ts as dependency #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems logical that it should be a "real" dependency. But the same is true for |
cgphilipp
approved these changes
Jul 20, 2020
|
@p-otto it seems that normally, with webpack we don't need "real" dependecies, see this article. However, something doesn't work here, so a long-term solution would be a different fix than adding a dependency. |
|
@scheibel Do you know why the continuous integration doesn't run and how I can debug this? |
anne-gropler
force-pushed
the
260-gltf-loader-ts-as-dep
branch
from
e587669 to
883c5bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260 .
Let me know if you have other ideas.