-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment rendering pass #230
Conversation
@cgcostume While working on this, I found out that we are handling cubemap faces in an incorrect way. The +x, -x, +z and -z faces have an inverted Y coordinate in comparison to the usual WebGL way of handling texture mapping: https://www.khronos.org/opengl/wiki/Cubemap_Texture#Upload_and_orientation Currently we are implicitly flipping all faces in One way to fix this is to perform the 180° rotation either in ERMT or during loading cubemaps in webgl-operate. How should we proceed here? |
|
@p-otto what's your opinion on this? |
@cgcostume Sounds good, maybe we can later add an export option for ERMT to target either WebGL or other tools/APIs that use the conventional format. |
This adds an
EnvironmentRenderingPass
, which renders four types of environment textures types via an ndc triangle.includes #244, merge after that one
closes #114