Skip to content

fix: prevent trimming so that wc -l is consistent #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2025
Merged

fix: prevent trimming so that wc -l is consistent #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9193626
fix: prevent trimming so that wc -l is consistent
algomaster99 Jan 5, 2025
e9e7bd3
Fix tests
algomaster99 Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/github/algomaster99/maven_module_graph/Utility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static void printToFile(MavenModule root, Path plainText, int indent) {

// Write to file
try {
Files.writeString(plainText, sb.toString().trim());
Files.writeString(plainText, sb.toString());
} catch (IOException e) {
e.printStackTrace();
}
Expand Down
1 change: 0 additions & 1 deletion src/test/java/io/github/algomaster99/maven_module_graph/MavenModuleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ void neo4j_profileModules(@TempDir Path temp) throws XmlPullParserException, IOE
Utility.printToJson(module, actualJson, 0);

// assert
// wc gives 124 as output because it does not count the last line without \n
assertThat(Files.readAllLines(expectedPlainText).size(), equalTo(125));
assertThat(Files.readString(expectedPlainText), equalTo(Files.readString(actualPlainText)));
assertThat(Files.readString(expectedJson), equalTo(Files.readString(actualJson)));
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/arthas/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ com.taobao.arthas:arthas-all:4.0.4
com.taobao.arthas:arthas-spy:4.0.4
com.taobao.arthas:arthas-common:4.0.4
com.taobao.arthas:math-game:4.0.4
com.taobao.arthas:web-ui:4.0.4
com.taobao.arthas:web-ui:4.0.4
2 changes: 1 addition & 1 deletion src/test/resources/legend-engine/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,4 +491,4 @@ org.finos.legend.engine:legend-engine:4.56.0
org.finos.legend.engine:legend-engine-executionPlan-execution-authorizer:4.56.0
org.finos.legend.engine:legend-engine-executionPlan-execution-http-api:4.56.0
org.finos.legend.engine:legend-engine-executionPlan-execution:4.56.0
org.finos.legend.engine:legend-engine-executionPlan-dependencies:4.56.0
org.finos.legend.engine:legend-engine-executionPlan-dependencies:4.56.0
2 changes: 1 addition & 1 deletion src/test/resources/neo4j/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,4 @@ org.neo4j:parent:5.3.0-SNAPSHOT
org.neo4j:neo4j-token-api:5.3.0-SNAPSHOT
org.neo4j.licensing-proxy:zstd-proxy:5.3.0-SNAPSHOT
org.neo4j.build:build-resources:5.3.0-SNAPSHOT
org.neo4j:annotations:5.3.0-SNAPSHOT
org.neo4j:annotations:5.3.0-SNAPSHOT
Loading