fix(menu): ensure unique ids #6759
Annotations
4 errors and 12 notices
e2e/tags-input.e2e.ts:38:7 › tags-input › delete tag by clearing its content and hit enter:
e2e/models/tags-input.model.ts#L86
1) e2e/tags-input.e2e.ts:38:7 › tags-input › delete tag by clearing its content and hit enter ────
Error: Timed out 10000ms waiting for expect(locator).toBeHidden()
Locator: locator('[data-testid=vue-tag]')
Expected: hidden
Received: visible
Call log:
- expect.toBeHidden with timeout 10000ms
- waiting for locator('[data-testid=vue-tag]')
14 × locator resolved to <div dir="ltr" data-value="Vue" data-highlighted="" data-testid="vue-tag" data-scope="tags-input" data-part="item-preview" id="tags-input::R6m::tag:Vue:1">…</div>
- unexpected value "visible"
at models/tags-input.model.ts:86
84 |
85 | async dontSeeTag(value: string) {
> 86 | await expect(this.getTag(value)).toBeHidden()
| ^
87 | }
88 |
89 | async seeInputIsFocused() {
at TagsInputModel.dontSeeTag (/home/runner/work/zag/zag/e2e/models/tags-input.model.ts:86:38)
at /home/runner/work/zag/zag/e2e/tags-input.e2e.ts:47:13
|
e2e/popover.e2e.ts:53:7 › popover › [keyboard / non-modal] on tab outside: should move focus to next tabbable element after button:
e2e/models/popover.model.ts#L87
1) e2e/popover.e2e.ts:53:7 › popover › [keyboard / non-modal] on tab outside: should move focus to next tabbable element after button
Error: Timed out 10000ms waiting for expect(locator).toBeFocused()
Locator: locator('[data-testid=button\\-after]')
Expected: focused
Received: inactive
Call log:
- expect.toBeFocused with timeout 10000ms
- waiting for locator('[data-testid=button\\-after]')
14 × locator resolved to <button data-testid="button-after">Button :after</button>
- unexpected value "inactive"
at models/popover.model.ts:87
85 |
86 | seeButtonAfterIsFocused() {
> 87 | return expect(this.buttonAfter).toBeFocused()
| ^
88 | }
89 |
90 | seeButtonBeforeIsFocused() {
at PopoverModel.seeButtonAfterIsFocused (/home/runner/work/zag/zag/e2e/models/popover.model.ts:87:37)
at /home/runner/work/zag/zag/e2e/popover.e2e.ts:57:13
|
e2e/popover.e2e.ts:60:7 › popover › [keyboard / non-modal] on shift-tab outside: should move focus to trigger:
e2e/models/popover.model.ts#L75
2) e2e/popover.e2e.ts:60:7 › popover › [keyboard / non-modal] on shift-tab outside: should move focus to trigger
Error: Timed out 10000ms waiting for expect(locator).toBeFocused()
Locator: locator('[data-scope=popover][data-part=trigger]')
Expected: focused
Received: inactive
Call log:
- expect.toBeFocused with timeout 10000ms
- waiting for locator('[data-scope=popover][data-part=trigger]')
14 × locator resolved to <button type="button" data-state="open" data-part="trigger" data-scope="popover" aria-expanded="true" aria-haspopup="dialog" data-placement="bottom" id="popover::R6m::trigger" data-testid="popover-trigger" aria-controls="popover::R6m::content">…</button>
- unexpected value "inactive"
at models/popover.model.ts:75
73 |
74 | seeTriggerIsFocused() {
> 75 | return expect(this.trigger).toBeFocused()
| ^
76 | }
77 |
78 | seeContentIsFocused() {
at PopoverModel.seeTriggerIsFocused (/home/runner/work/zag/zag/e2e/models/popover.model.ts:75:33)
at /home/runner/work/zag/zag/e2e/popover.e2e.ts:64:13
|
e2e/menu-option.e2e.ts:26:7 › menu option › keyboard:
e2e/models/menu.model.ts#L89
1) e2e/menu-option.e2e.ts:26:7 › menu option › keyboard, should check/uncheck radio item ─────────
Error: Timed out 10000ms waiting for expect(locator).toHaveAttribute(expected)
Locator: locator('[data-part=item]').filter({ hasText: 'Descending' })
Expected string: "checked"
Received string: "unchecked"
Call log:
- expect.toHaveAttribute with timeout 10000ms
- waiting for locator('[data-part=item]').filter({ hasText: 'Descending' })
14 × locator resolved to <div id=":R6m:/desc" data-part="item" data-scope="menu" data-value="desc" data-type="radio" role="menuitemradio" aria-checked="false" data-valuetext="desc" data-state="unchecked" data-ownedby="menu::R6m::content">…</div>
- unexpected value "unchecked"
at models/menu.model.ts:89
87 | seeItemIsChecked = async (text: string) => {
88 | const item = this.getItem(text)
> 89 | await expect(item).toHaveAttribute("data-state", "checked")
| ^
90 | }
91 |
92 | seeItemIsNotChecked = async (text: string) => {
at MenuModel.seeItemIsChecked (/home/runner/work/zag/zag/e2e/models/menu.model.ts:89:24)
at /home/runner/work/zag/zag/e2e/menu-option.e2e.ts:38:13
|
🎭 Playwright Run Summary
1 skipped
26 passed (44.6s)
|
🎭 Playwright Run Summary
1 flaky
e2e/tags-input.e2e.ts:38:7 › tags-input › delete tag by clearing its content and hit enter ─────
11 skipped
18 passed (48.1s)
|
🎭 Playwright Run Summary
1 skipped
21 passed (37.9s)
|
🎭 Playwright Run Summary
1 skipped
29 passed (55.3s)
|
🎭 Playwright Run Summary
1 skipped
22 passed (44.7s)
|
🎭 Playwright Run Summary
3 skipped
26 passed (1.2m)
|
🎭 Playwright Run Summary
28 passed (53.0s)
|
🎭 Playwright Run Summary
38 passed (1.0m)
|
🎭 Playwright Run Summary
2 skipped
32 passed (51.6s)
|
🎭 Playwright Run Summary
2 flaky
e2e/popover.e2e.ts:53:7 › popover › [keyboard / non-modal] on tab outside: should move focus to next tabbable element after button
e2e/popover.e2e.ts:60:7 › popover › [keyboard / non-modal] on shift-tab outside: should move focus to trigger
2 skipped
26 passed (1.2m)
|
🎭 Playwright Run Summary
1 flaky
e2e/menu-option.e2e.ts:26:7 › menu option › keyboard, should check/uncheck radio item ──────────
11 skipped
9 passed (42.9s)
|
🎭 Playwright Run Summary
1 skipped
33 passed (1.1m)
|