Move effect deps to implementation getter and require array return#3022
Closed
Move effect deps to implementation getter and require array return#3022
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: segunadebayo <6916170+segunadebayo@users.noreply.github.com>
Co-authored-by: segunadebayo <6916170+segunadebayo@users.noreply.github.com>
Co-authored-by: segunadebayo <6916170+segunadebayo@users.noreply.github.com>
Co-authored-by: segunadebayo <6916170+segunadebayo@users.noreply.github.com>
Co-authored-by: segunadebayo <6916170+segunadebayo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for effect dependencies across machine core and framework bindings
feat: add effect dependency tracking across bindings
Mar 12, 2026
Co-authored-by: segunadebayo <6916170+segunadebayo@users.noreply.github.com>
Copilot
AI
changed the title
feat: add effect dependency tracking across bindings
feat: rename effect descriptor key to type
Mar 12, 2026
Co-authored-by: segunadebayo <6916170+segunadebayo@users.noreply.github.com>
Copilot
AI
changed the title
feat: rename effect descriptor key to type
Move effect deps onto implementations
Mar 12, 2026
Co-authored-by: segunadebayo <6916170+segunadebayo@users.noreply.github.com>
Copilot
AI
changed the title
Move effect deps onto implementations
Move effect deps to implementation getter and require array return
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
📝 Description
Effect dependencies now belong to the effect implementation itself and must be returned via a deps getter that always yields an array, simplifying descriptors to
typeonly.⛳️ Current behavior (updates)
Effect descriptors could carry
deps, and dependency resolvers accepted optional/undefined returns, requiring extra defensive logic.🚀 New behavior
EffectDepsis a required getter(params) => EffectDepsValue[]; descriptors remaintype-only.Example:
💣 Is this a breaking change (Yes/No):
Yes — deps must now be supplied on the implementation via a required getter; effect descriptors no longer accept deps.
📝 Additional Information
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.