Slang integration #117
Open
Slang integration #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added entry point for a create pipeline function - Removed descriptor buffer enable struct
loosche
reviewed
Jul 22, 2024
| sessionDesc.targetCount = 1; | ||
| sessionDesc.defaultMatrixLayoutMode = SLANG_MATRIX_LAYOUT_COLUMN_MAJOR; | ||
| sessionDesc.compilerOptionEntries = compilerOptions.data(); | ||
| sessionDesc.compilerOptionEntryCount = static_cast<uint32_t>(compilerOptions.size()); |
There was a problem hiding this comment.
You could just use DataPtr(compilerOptions); and CountU32(compilerOptions); couldn't you?
loosche
reviewed
Jul 22, 2024
| *pErrorMsg = "unable to retrieve SPIR-V blob for library"; | ||
| } | ||
|
|
||
| return COMPILE_ERROR_INTERNAL_COMPILER_ERROR; |
There was a problem hiding this comment.
Feels like you might want some kind of SLANG_CALL_SAFE() macro or function to deal with this kind of stuff? Instead of calling it all over the place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.