Skip to content

Conversation

@Neamar
Copy link

@Neamar Neamar commented Mar 10, 2014

This is a "small" yet useful PR, with several features:

  • Allow for complex, custom IMAP queries using new custom_query parameter
  • Store mailbox attributes. This is better for i18n, since "All Mail" only exists on english GMail (and the only way to retrieve the "all mail" name is to look for "\All" in the attributes)
  • Parse from and to headers (quoted printable content)
  • Encode body and text from mail_encoding to unicode

Sorry, should have broken this into several smaller PR.

@Neamar
Copy link
Author

Neamar commented May 28, 2014

EDIT: this has grown of its own to handle all special cases i kept seeing. This may not be good to merge now. The choice is yours.

gmail/message.py Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why duplicate make a duplicate function that just calls try_parse?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proboaby some leftover from previous code. Nicely spotted, removing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants