Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

horizontal scrolls and other improvements #791

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

horizontal scrolls and other improvements #791

wants to merge 19 commits into from

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jan 7, 2025

pager:

  • search input width
  • horizontal scroll

filter:

  • horizontal scroll

@caarlos0
Copy link
Member Author

caarlos0 commented Jan 7, 2025

I feel like viewport needs something similar to a sign column as well.

right now it scrolls line numbers and the line selection as well, as they are part of the viewport content...

ccoVeille
ccoVeille reviewed Jan 9, 2025
View reviewed changes
@caarlos0
wip
b8988fd 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0
wip
6f6a9d2 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
meowgorithm
meowgorithm reviewed Jan 22, 2025
View reviewed changes
meowgorithm
meowgorithm reviewed Jan 22, 2025
View reviewed changes
@caarlos0 caarlos0 requested a review from a team as a code owner January 23, 2025 13:50
@caarlos0 caarlos0 requested review from csandeep and removed request for a team January 23, 2025 13:50
@caarlos0 caarlos0 mentioned this pull request Jan 23, 2025
Merged
@caarlos0
Copy link
Member Author

scroll to bottom doesn't work when soft wrapping, fixing

@caarlos0
chore: update
59bb14c 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0
Copy link
Member Author

ok, this should all be working now.
Check charmbracelet/bubbles#697 for the actual thing :kek:

@caarlos0
chore: fixes
d7ec390
@caarlos0
chore: readme
528a1cf 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0
chore: revert
e1d07d5 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
This was referenced Jan 28, 2025
Closed
Merged
@caarlos0
Copy link
Member Author

will leave this for after bubbletea v2

@caarlos0 caarlos0 added the blocked blocked by some other issue and/or pr label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm meowgorithm left review comments

@ccoVeille ccoVeille ccoVeille left review comments

@aymanbagabas aymanbagabas aymanbagabas approved these changes

@csandeep csandeep Awaiting requested review from csandeep csandeep is a code owner automatically assigned from charmbracelet/everyone

Assignees
No one assigned
Labels
blocked blocked by some other issue and/or pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caarlos0 @meowgorithm @aymanbagabas @ccoVeille