Skip to content

refactor:changed new,link and mask png to svg#168

Open
Surajsuthar wants to merge 3 commits into
chase-mew:mainfrom
Surajsuthar:feat/change_layer_footer_png_to_svg
Open

refactor:changed new,link and mask png to svg#168
Surajsuthar wants to merge 3 commits into
chase-mew:mainfrom
Surajsuthar:feat/change_layer_footer_png_to_svg

Conversation

@Surajsuthar

Copy link
Copy Markdown
Contributor

@chase-mew

Copy link
Copy Markdown
Owner

The SVGs look different to the PNGs. For example, this is the new png:
image
And this is the svg:
image
The svg has various artifacts and doesn't look identical to the png.

I think these SVGs were created from a png > svg tool. Which unfortunately are known for generating large svgs, and creating artifacts. I think for this png > svg migration, we will want to manually create the SVGs using a tool like Inkscape or Adobe Illustrator etc. Otherwise we're not really improving the codebase, as the assets will look worse and not reduce in size.

@Surajsuthar

Copy link
Copy Markdown
Contributor Author

@chase-manning thanks for pointing it out. I will try to create it manually.

@Surajsuthar

Copy link
Copy Markdown
Contributor Author

Frame 99
this will work?

@chase-mew

Copy link
Copy Markdown
Owner

The svg looks off for a couple of reasons. It needs to match the icon exactly otherwise it is changing the functionality. In this case the svg has a background, but the icon has no background (is transparent). Also the svg is a different color to the icon. The icon has #DDDCDD as it's color, but the color of the svg is white. Other than that though, the shape and style and content of the SVG look good. Just need some color tweaks really and removing the background 😃

@Surajsuthar

Copy link
Copy Markdown
Contributor Author

new

sorry for delay, here is new updated svg

@chase-mew

Copy link
Copy Markdown
Owner

@Surajsuthar Looks great thanks! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants