Document Web Vitals for Playwright Check Suites#447
Open
kiroushi wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you Javier! reads great overall. Below some minor nits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Web Vitals for Playwright Check Suites page under the Playwright Check Suites section, and cross-links it with the existing Browser Checks performance page (both ways).
Why
Web Vitals collection for Playwright Check Suites has grown since the Browser Checks page was written. This documents the current behaviour:
Notes
<Accordion>metrics with web.dev links,<Callout>asides, second-person).