Envvar handling fixups#3024
Open
tursulin wants to merge 4 commits into
Open
Conversation
added 4 commits
May 20, 2026 09:08
Copilot reports %d is correct for boolean and %zx for size_t, fix it. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com> Fixes: 1961c5e ("plugins/amdgpu: Cleanup env variable handling")
Copilot reports a possible false positive error on strtoul conversion due errno not being reset on success. Fix it by clearing errnor prior to the call. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Commit 1961c5e ("plugins/amdgpu: Cleanup env variable handling") converted some error logs into warnings under the rationale of failures not being fatal, but the execution continues with the default values. Convert one more such error to a warning, as pointed out by Copilot that makes things more consistent. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Copilot reports quotes in one warning message are unbalanced - fix it. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
tursulin
force-pushed
the
envvar-handling-fixups
branch
from
a7592d9 to
94d5967
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## criu-dev #3024 +/- ##
============================================
- Coverage 57.01% 56.98% -0.04%
============================================
Files 154 154
Lines 40452 40449 -3
Branches 8866 8867 +1
============================================
- Hits 23064 23048 -16
- Misses 17034 17047 +13
Partials 354 354 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up fixes/cleanups after 1961c5e ("plugins/amdgpu: Cleanup env variable handling")