Issue #14482: Replace UnmodifiableCollectionUtil in LocalizedMessage.#19696
Open
Carbon14-48 wants to merge 1 commit intocheckstyle:masterfrom
Open
Issue #14482: Replace UnmodifiableCollectionUtil in LocalizedMessage.#19696Carbon14-48 wants to merge 1 commit intocheckstyle:masterfrom
Carbon14-48 wants to merge 1 commit intocheckstyle:masterfrom
Conversation
…edMessage and kill according mutation
Member
|
we do not allow pure unit testing, all should be by verifyXxxxxx and pitest should completely ingore this method, if not ingnoring, lets create issue on it. |
Contributor
Author
yessss i have created an issue with all the methods in this and other PRs , hopefully we get a paramter to skip methods they now only have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #14482
the exact same pattern as #19695
Pitest's
ArgumentPropagationMutatortries to prove that the defensive copy (Arrays.copyOf) is unnecessary, It does this by making the class point directly to the original array we passed in. this is why we add a test that modifies the array after construction and checks the message to killl the mutation