Skip to content

Issue #14482: Replace UnmodifiableCollectionUtil in LocalizedMessage.#19696

Open
Carbon14-48 wants to merge 1 commit intocheckstyle:masterfrom
Carbon14-48:issue-14482-remove-umodifiableutil-localizedmessage
Open

Issue #14482: Replace UnmodifiableCollectionUtil in LocalizedMessage.#19696
Carbon14-48 wants to merge 1 commit intocheckstyle:masterfrom
Carbon14-48:issue-14482-remove-umodifiableutil-localizedmessage

Conversation

@Carbon14-48
Copy link
Copy Markdown
Contributor

@Carbon14-48 Carbon14-48 commented Apr 13, 2026

Issue #14482

the exact same pattern as #19695

Pitest's ArgumentPropagationMutator tries to prove that the defensive copy (Arrays.copyOf) is unnecessary, It does this by making the class point directly to the original array we passed in. this is why we add a test that modifies the array after construction and checks the message to killl the mutation

@romani
Copy link
Copy Markdown
Member

romani commented Apr 18, 2026

we do not allow pure unit testing, all should be by verifyXxxxxx and pitest should completely ingore this method, if not ingnoring, lets create issue on it.

Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@Carbon14-48
Copy link
Copy Markdown
Contributor Author

we do not allow pure unit testing, all should be by verifyXxxxxx and pitest should completely ingore this method, if not ingnoring, lets create issue on it.

yessss i have created an issue with all the methods in this and other PRs , hopefully we get a paramter to skip methods they now only have avoidCallTo which works only at class level so all calls to Collections will be skipped which is too broad

@romani romani added the blocked label Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants