config: Added checkstyle's commit message CI test#388
config: Added checkstyle's commit message CI test#388romani merged 1 commit intocheckstyle:masterfrom
Conversation
|
Can we reuse https://github.com/marketplace/actions/gitlint-action |
cf595dc to
b0e6d8f
Compare
|
I think its better we use gitlint-action and modify it to checkstyle's rules, made the changes. |
|
I still see bunch of bash scripting instead of action reusage |
1d6f156 to
0b88bfb
Compare
|
@romani made the changes , added .gitlint file in project root repo with checkstyle commit rules and linter.yml in |
|
CI is red |
|
add new lines to all files you added |
1e5cf02 to
5f6364d
Compare
|
The CI now uses gitlint with a configuration aligned to Checkstyle’s commit message rules. It validates: Required patterns (Issue #, Pull #, or allowed prefixes) I added new line at end of both the files , i think github is not showing it. Thanks for guiding me patiently . It means a lot . |
|
Code is good, please add new commit with any update in code and bad commit message, I want to see CI failure. |
5f6364d to
b616b06
Compare
|
@romani should i add a section in linter.yml file that outputs clear error message upon ci failure like in checkstyle. |
https://github.com/checkstyle/patch-filters/actions/runs/24703915425/job/72252838475?pr=388 all good. please remove text commit, lets merge this PR. |
b616b06 to
8385f1c
Compare
|
@romani ping |
romani
left a comment
There was a problem hiding this comment.
Thanks a lot.
Let's see how this works in long run.
Addded a ci job that matches the commit message format to that of CheckStyle's.