Skip to content

Normalize HTML attribute lookups to lower case #4892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Normalize HTML attribute lookups to lower case #4892

wants to merge 1 commit into from

Conversation

@afadesigns
Copy link

Summary

  • normalize attribute name handling so HTML .attr/.removeAttr lookups treat names case-insensitively
  • update attribute helpers to normalize storage while leaving XML mode untouched
  • add regression tests for HTML and XML attribute casing

Testing

  • npm run test:vi -- src/api/attributes.spec.ts

Fixes #581.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.attr(name) should lowercase name property

1 participant

@afadesigns