Skip to content

Sean simmons progress/chef 21530 platform support windows2025#168

Open
sean-sype-simmons wants to merge 5 commits intomainfrom
sean-simmons-progress/CHEF-21530-PlatformSupportWindows2025
Open

Sean simmons progress/chef 21530 platform support windows2025#168
sean-sype-simmons wants to merge 5 commits intomainfrom
sean-simmons-progress/CHEF-21530-PlatformSupportWindows2025

Conversation

@sean-sype-simmons
Copy link
Contributor

A few fixes for the gemfile.lock, also adding new platforms once we merge in changes to our build infra.

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Sean Simmons <sean.simmons@progress.com>
Signed-off-by: Sean Simmons <sean.simmons@progress.com>
Signed-off-by: Sean Simmons <sean.simmons@progress.com>
removing 2012

Signed-off-by: Sean Simmons <sean.simmons@progress.com>
@sean-sype-simmons sean-sype-simmons requested a review from a team as a code owner July 11, 2025 12:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the new Windows 2025 platform to our Omnibus build and test configurations and updates CI hooks accordingly

  • Expand builder-to-testers-map in both release and adhoc-canary Expeditor configs to include the Windows 2025 tester
  • Correct and realign Windows builder mappings in .expeditor/* YAML files
  • Extend the Buildkite pre-command hook regex to recognize the adhoc-canary pipeline

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
.expeditor/release.omnibus.yml Added windows-2025-x86_64 tester and updated the Windows builders mapping
.expeditor/adhoc-canary.omnibus.yml Added windows-2025-x86_64 tester and cleaned up mapping indentation
.buildkite/hooks/pre-command Updated pipeline name regex to include adhoc-canary
Comments suppressed due to low confidence (5)

.expeditor/release.omnibus.yml:95

  • This introduces a duplicate windows-2019-x86_64 mapping key, which will break YAML parsing. Merge the entries under the existing key rather than adding a new one.
  windows-2019-x86_64:

.expeditor/release.omnibus.yml:99

  • This tester entry duplicates the very first entry in the list. Remove the redundant - windows-2019-x86_64 to avoid running the same platform twice.
    - windows-2019-x86_64

.expeditor/release.omnibus.yml:101

  • There are trailing spaces at the end of this line. Removing them will keep the file clean and avoid spurious diff noise.
    - windows-2025-x86_64    

.expeditor/adhoc-canary.omnibus.yml:96

  • The indentation of this mapping key doesn’t align with the other builders. Align it with its peers so the YAML parser treats it as the same top‐level key.
  windows-2019-x86_64:

.expeditor/adhoc-canary.omnibus.yml:100

  • This line has trailing whitespace. Removing it will avoid unnecessary diffs and keep formatting consistent.
    - windows-2025-x86_64    

Signed-off-by: Sean Simmons <sean.simmons@progress.com>
@muthuja
Copy link
Contributor

muthuja commented Jul 29, 2025

it seems like we have picked current pr changes in this pr #176 and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants