Sean simmons progress/chef 21530 platform support windows2025#168
Open
sean-sype-simmons wants to merge 5 commits intomainfrom
Open
Sean simmons progress/chef 21530 platform support windows2025#168sean-sype-simmons wants to merge 5 commits intomainfrom
sean-sype-simmons wants to merge 5 commits intomainfrom
Conversation
Signed-off-by: Sean Simmons <sean.simmons@progress.com>
Signed-off-by: Sean Simmons <sean.simmons@progress.com>
Signed-off-by: Sean Simmons <sean.simmons@progress.com>
removing 2012 Signed-off-by: Sean Simmons <sean.simmons@progress.com>
There was a problem hiding this comment.
Pull Request Overview
Adds the new Windows 2025 platform to our Omnibus build and test configurations and updates CI hooks accordingly
- Expand
builder-to-testers-mapin both release and adhoc-canary Expeditor configs to include the Windows 2025 tester - Correct and realign Windows builder mappings in
.expeditor/*YAML files - Extend the Buildkite pre-command hook regex to recognize the
adhoc-canarypipeline
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .expeditor/release.omnibus.yml | Added windows-2025-x86_64 tester and updated the Windows builders mapping |
| .expeditor/adhoc-canary.omnibus.yml | Added windows-2025-x86_64 tester and cleaned up mapping indentation |
| .buildkite/hooks/pre-command | Updated pipeline name regex to include adhoc-canary |
Comments suppressed due to low confidence (5)
.expeditor/release.omnibus.yml:95
- This introduces a duplicate
windows-2019-x86_64mapping key, which will break YAML parsing. Merge the entries under the existing key rather than adding a new one.
windows-2019-x86_64:
.expeditor/release.omnibus.yml:99
- This tester entry duplicates the very first entry in the list. Remove the redundant
- windows-2019-x86_64to avoid running the same platform twice.
- windows-2019-x86_64
.expeditor/release.omnibus.yml:101
- There are trailing spaces at the end of this line. Removing them will keep the file clean and avoid spurious diff noise.
- windows-2025-x86_64
.expeditor/adhoc-canary.omnibus.yml:96
- The indentation of this mapping key doesn’t align with the other builders. Align it with its peers so the YAML parser treats it as the same top‐level key.
windows-2019-x86_64:
.expeditor/adhoc-canary.omnibus.yml:100
- This line has trailing whitespace. Removing it will avoid unnecessary diffs and keep formatting consistent.
- windows-2025-x86_64
poorndm
approved these changes
Jul 11, 2025
Signed-off-by: Sean Simmons <sean.simmons@progress.com>
rahulgoel1
approved these changes
Jul 28, 2025
Contributor
|
it seems like we have picked current pr changes in this pr #176 and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few fixes for the gemfile.lock, also adding new platforms once we merge in changes to our build infra.
Description
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.