Fixed CSR parsing for spike csv generation #1012
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have also encountered the issue #919 , specifically the 4th case. In my experience the other three work as I expected.
I believe I have solved the issue. The main cause of the issue was that, for some floating point instructions, the CSR values are written before the register values, and for some instructions after the register values. The current parser script "spike_log_to_trace_csv.py" can only detect the cases in which the CSR values are written at the end.
By modifying the regex script to check for both positions, and writing only the valid output seems to have worked for me.
I'm making this pull request if anyone wants to double check it and apply the fix.