Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Freecad) Fail Safe for Null Versions #1497

Closed
wants to merge 1 commit into from

Conversation

RedBaron2
Copy link
Contributor

@AdmiringWorm @majkinetor @gep13 @pascalberger

Description

This is a Fail Safe for if no Version found to not halt the other streams from being updated, and spacing issue in the code.

Motivation and Context

The error report for the AU Update linked above.

How Has this Been Tested?

Tested locally and on Appveyor

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

Original Location

  • Original Repository
  • Open Issues Add the different issues underneath, and tick those that are fixed in this PR
    • Issue 1 link
    • Issue 2 Link
  • Include the link to the opened PR that removes the package from the original location
  • The migration guidelines have been followed

Fail Safe for if no Version found
spacing issue
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@majkinetor
Copy link
Contributor

I never tried it, but perhaps returning ignore for that stream would be more telling option if it works.

@RedBaron2
Copy link
Contributor Author

@majkinetor
I'll test it out and report back

@RedBaron2
Copy link
Contributor Author

@majkinetor @AdmiringWorm
I'm going to close this due to the fact that making it to use the ignore would mean rewriting the whole thing to check the hash being written to the current stream hash.
The FreeCAD developers where able to fix the error that caused the null in the first place.
Thanks all for the input 👍

@RedBaron2 RedBaron2 closed this Jun 26, 2020
@RedBaron2 RedBaron2 deleted the patch-25 branch July 11, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants