Open
Conversation
trescenzi
force-pushed
the
upgrade-to-erlang-otp-v1
branch
2 times, most recently
from
2c6f6d1 to
3de087a
Compare
trescenzi
force-pushed
the
upgrade-to-erlang-otp-v1
branch
from
3de087a to
0e890d5
Compare
trescenzi
changed the title
Owner
|
Thank you! There are some tricky bits about chip so will review this and next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are all passing however the benchmark still isn't working. Will dig into that now.Test are passing and the benchmark runs as well. I've updated the example readmes as well.
I'm not 100% confident that I did this entirely correctly even with everything passing simply because this is a rather complex module. I'm going to be using my fork in a project as a pub/sub tool and if I find any issues I'll update it.