Skip to content

Fix thread_poll joinable should be atomic #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Fix thread_poll joinable should be atomic #1668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions asio/include/asio/impl/thread_pool.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,9 @@ void thread_pool::attach()

void thread_pool::join()
{
if (joinable_)
bool expected = true;
if (joinable_.compare_exchange_strong(expected, false))
{
joinable_ = false;
scheduler_.work_finished();
threads_.join();
}
Expand Down
2 changes: 1 addition & 1 deletion asio/include/asio/thread_pool.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ class thread_pool
detail::atomic_count num_threads_;

// Whether a join call will have any effect.
bool joinable_;
std::atomic<bool> joinable_;
};

/// Executor implementation type used to submit functions to a thread pool.
Expand Down