fix(feed): redact user-controlled fields on JSONL load (#298) - #472
Open
christopherkarani wants to merge 7 commits into
Open
fix(feed): redact user-controlled fields on JSONL load (#298)#472christopherkarani wants to merge 7 commits into
christopherkarani wants to merge 7 commits into
Conversation
Co-authored-by: Christopher Karani <chrisbkarani@gmail.com>
Replace whole-line redactAlloc of feed .raw with writeFeedRecordJson from already-redacted fields so high-entropy JSONL stays parseable. Secret-shaped session_id values become the path-safe placeholder "redacted" instead of [REDACTED:…], which breaks validateSessionIdText. Co-authored-by: Christopher Karani <chrisbkarani@gmail.com>
Co-authored-by: Christopher Karani <chrisbkarani@gmail.com>
Co-authored-by: Christopher Karani <chrisbkarani@gmail.com>
Unanchored `sk-` matches inside `task-<uuid>` and `ask-followup-1`. Accept findStructuredSecret hits only at isKeyStart so Hermes task ids survive while `sess-sk-` still becomes the path-safe placeholder. Co-authored-by: Christopher Karani <chrisbkarani@gmail.com>
OpenCode and host ids use `sess_` / `ses_`. Env-var isKeyStart treats `_` as interior, so `sess_ghp_…` survived. Gate on non-alnum instead. Co-authored-by: Christopher Karani <chrisbkarani@gmail.com>
christopherkarani
marked this pull request as ready for review
August 16, 2026 15:51
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Load-path host/pack_id/severity go through redactOwnedAllocOptional. writeFeedRecordJson gates session_id with containsStructuredSecret so ghp_ cannot persist. Embedded AKIA after a session boundary becomes redacted. stack.append OOM deinits the in-flight LoadedFeedRecord. Co-authored-by: Christopher Karani <chrisbkarani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #298.
What changed
Load-path redaction for historical feed JSONL:
reason/remediation/target_summary/rule/host/pack_id/severitygo throughcore_api.redactAlloc..rawis rebuilt from the parsed record.session_iduses a path-saferedactedplaceholder whencontainsStructuredSecrethits a provider token at a non-alnum boundary (sotask-/ask-followup-1survive, whilesess.ghp_/sess-sk-/sess_ghp_/sess_AKIA…do not). High-entropy / JWT classify is not used on session ids.writeFeedRecordJsonalso gatessession_idso append-time JSONL cannot persist a rawghp_host id.stack.appendOOM deinits the in-flightLoadedFeedRecord.Review
Five independent 3-agent waves on the claimed load-path surface were 0/0. Leftover commit
2e388471fresh wave: 0 Critical / 0 Important. Ready to merge after rebase onto currentmain(feed_writer.zigchanged on both sides).Checks
./scripts/zig build -j1 -Dincremental=false -Dtest-filter="feed" test-lib— 71/71 (includes new host/pack_id/severity, append-time session_id, and embedded AWS rows)Out of scope
blockedsk-/xghp_session ids (do not changefindStructuredSecret)