Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Intro to Storybook (React) - Update the french doc based on the english version #797

Merged
merged 13 commits into from
Jan 27, 2025

Conversation

VassoD
Copy link
Contributor

@VassoD VassoD commented Jan 12, 2025

Updating the french doc based on the english version

@VassoD VassoD marked this pull request as ready for review January 14, 2025 18:21
@VassoD VassoD changed the title Docs: Intro to Storybook - Update the french doc based on the english version Docs: Intro to Storybook (React) - Update the french doc based on the english version Jan 14, 2025
Copy link
Collaborator

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VassoD Thank you very much for the updates to the translation. I appreciate it 🙏 ! I've left a few items for you to look into when you can. Let me know once you've addressed them, and I'll take another look.

Also, @jeanphi-baconnais, would you be interested in taking a pass at this pull request and letting @VassoD know of any issues you find?

Have a fantastic day.

Stay safe

```diff:title=src/components/InboxScreen.stories.js
import React from 'react';

```diff:title=src/components/InboxScreen.stories.jsx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VassoD can you take another look at this section (i.e., Tests d'intéraction and Ecrire un test d'interaction en utilisant la fonction play) and adjust it to match the English version? It's slightly different; we're referring to them as Component tests. The text will also need a bit of polish as well.

Copy link
Contributor Author

@VassoD VassoD Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, let me know if it's ok now :)

@jeanphi-baconnais
Copy link

Yes of course, I can try to review this PR next week 🙂

@jonniebigodes
Copy link
Collaborator

@jeanphi-baconnais appreciate it 🙏 . Let me know and we'll go from there.

Have a fantastic weekend.

Stay safe

Copy link

@jeanphi-baconnais jeanphi-baconnais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I have not comment to do, great work 👏

Copy link
Collaborator

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VassoD, thanks for promptly addressing the feedback. I appreciate it 🙏 ! @jeanphi-baconnais, I appreciate you taking a look at this pull request as well. I'm good with it and will merge it so we can publish it.

Hope both of you have a fantastic week.

Stay safe

@jonniebigodes jonniebigodes merged commit 57dc35f into chromaui:master Jan 27, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants