[Buganizer ID: 461900756] Fix: Pull Playbook Integration Instance Handling in Git Sync #329
+19
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When importing a playbook using PullPlaybook, if the specific integration instance used in the exported playbook was missing in the target environment, the system failed to select a fallback instance if the available instances were not "configured" (i.e., isConfigured was false). This resulted in steps having no integration instance selected.
How does this PR solve the problem?
We retrieved all instances of the integration on the target platform, not just the configured ones. We then applied the fallback mechanism to select the first instance among them of the same integration type.
Approach to solve the problem
Modified the
GitSyncManager._find_integration_instances_for_stepmethod to:isConfiguredis false.Any other relevant information:
This happens because when creating a playbook and selecting a specific environment, the platform currently lacks the option for the user to be able to provide a fall back to a specific integration instance.
However, when creating a playbook and selecting "All Environments," the platform does provide the fallback instance option. We already implemented this fix in one of our earlier releases.