Skip to content

Conversation

@adarshtwy
Copy link

@adarshtwy adarshtwy commented Nov 21, 2025


What problem does this PR solve?
When importing a playbook using PullPlaybook, if the specific integration instance used in the exported playbook was missing in the target environment, the system failed to select a fallback instance if the available instances were not "configured" (i.e., isConfigured was false). This resulted in steps having no integration instance selected.

How does this PR solve the problem?
We retrieved all instances of the integration on the target platform, not just the configured ones. We then applied the fallback mechanism to select the first instance among them of the same integration type.

Approach to solve the problem
Modified the GitSyncManager._find_integration_instances_for_step method to:

  • Include unconfigured instances by removing the filter that excluded instances where isConfigured is false.
  • Prioritize configured instances by sorting the list of candidate instances so that configured instances appear first.

Any other relevant information:
This happens because when creating a playbook and selecting a specific environment, the platform currently lacks the option for the user to be able to provide a fall back to a specific integration instance.

However, when creating a playbook and selecting "All Environments," the platform does provide the fallback instance option. We already implemented this fix in one of our earlier releases.


@adarshtwy adarshtwy requested a review from a team as a code owner November 21, 2025 10:52
@github-actions
Copy link

Marketplace Validation Failed

Click to view the full report

Pre-Build Validation:

Click to view details

🧩 git_sync

Validation Name Details
⚠️ Uv Lock Error happened while executing a command: uv lock --check: Using CPython 3.11.14 interpreter at: /opt/hostedtoolcache/Python/3.11.14/x64/bin/python Resolved 66 packages in 1.17s The lockfile at uv.lock needs to be updated, but --check was provided. To update the lockfile, run uv lock.

@adarshtwy adarshtwy self-assigned this Nov 21, 2025
@adarshtwy adarshtwy added Bug Something isn't working Python Pull requests that update python code Under Review Git Sync labels Nov 21, 2025
@adarshtwy adarshtwy removed the request for review from KrishnaSharma06 December 5, 2025 12:21
@github-actions github-actions bot added the Stale label Dec 27, 2025
@github-actions github-actions bot removed the Stale label Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Git Sync Python Pull requests that update python code Under Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants