FIX: Resolve dependencies issues in deconstruct flow #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @haggit-eliyahu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves several critical dependency management issues within the project's deconstruct flow. The changes streamline the process of installing both remote and local Python packages, ensuring that development environments are consistently set up with all necessary dependencies, including development-specific tools and internal libraries. This leads to a more reliable and efficient build and testing process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
haggit-eliyahu
force-pushed
the
resolve-dependencies-in-deconstruct
branch
from
e6e893e to
3938b49
Compare
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageinfoblox_threat_defense_with_ddi
team_cymru_scout
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements to dependency resolution in the deconstruct flow. The changes, including adding a default PyPI index, handling local wheel dependencies, and automatically adding default development dependencies, are well-implemented. I've identified a potential bug in the version comparison logic and have a couple of suggestions for refactoring and improving consistency, which I've detailed in the comments below.
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageteam_cymru_scout
infoblox_threat_defense_with_ddi
|
1 similar comment
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageteam_cymru_scout
infoblox_threat_defense_with_ddi
|
haggit-eliyahu
force-pushed
the
resolve-dependencies-in-deconstruct
branch
from
115f7c4 to
295f9ee
Compare
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageinfoblox_threat_defense_with_ddi
team_cymru_scout
|
haggit-eliyahu
force-pushed
the
resolve-dependencies-in-deconstruct
branch
from
295f9ee to
2fee1c1
Compare
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageinfoblox_threat_defense_with_ddi
team_cymru_scout
|
haggit-eliyahu
force-pushed
the
resolve-dependencies-in-deconstruct
branch
from
2fee1c1 to
6ddfefd
Compare
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageinfoblox_threat_defense_with_ddi
team_cymru_scout
|
haggit-eliyahu
force-pushed
the
resolve-dependencies-in-deconstruct
branch
from
6ddfefd to
8975476
Compare
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageinfoblox_threat_defense_with_ddi
team_cymru_scout
|
haggit-eliyahu
force-pushed
the
resolve-dependencies-in-deconstruct
branch
6 times, most recently
from
3fd52ae to
39d8f6d
Compare
…es to the packages directory # Conflicts: # packages/mp/pyproject.toml # packages/mp/uv.lock # Conflicts: # packages/mp/pyproject.toml # packages/mp/uv.lock
haggit-eliyahu
force-pushed
the
resolve-dependencies-in-deconstruct
branch
2 times, most recently
from
661f230 to
aaccf4d
Compare
haggit-eliyahu
force-pushed
the
resolve-dependencies-in-deconstruct
branch
from
aaccf4d to
2393f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the depnedencies resolution in the decunstruct flow by:
Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only:
Screenshots (If Applicable)
If your changes involve UI or visual elements, please include screenshots or GIFs here.
Ensure any sensitive data is redacted or generalized.
Further Comments / Questions
Any additional comments, questions, or areas where you'd like specific feedback.