Skip to content

Conversation

@KrishnaSharma06
Copy link
Contributor

@KrishnaSharma06 KrishnaSharma06 commented Dec 24, 2025

Tools - Updated TIPCommon whl to migrate GetCaseFullDetails to 1P.

Bug ID: b/455834066

Checklist:

Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.

General Checks:

  • I have read and followed the project's contributing.md guide.
  • My code follows the project's coding style guidelines.
  • I have performed a self-review of my own code.
  • My changes do not introduce any new warnings.
  • My changes pass all existing tests.
  • I have added new tests where appropriate to cover my changes. (If applicable)
  • I have updated the documentation where necessary (e.g., README, API docs). (If applicable)

Open-Source Specific Checks:

  • My changes do not introduce any Personally Identifiable Information (PII) or sensitive customer data.
  • My changes do not expose any internal-only code examples, configurations, or URLs.
  • All code examples, comments, and messages are generic and suitable for a public repository.
  • I understand that any internal context or sensitive details related to this work are handled separately in internal systems (Buganizer for Google team members).

For Google Team Members and Reviewers Only:

  • I have included the Buganizer ID in the PR title or description (e.g., "Internal Buganizer ID: 123456789" or "Related Buganizer: go/buganizer/123456789").
  • I have ensured that all internal discussions and PII related to this work remain in Buganizer.
  • I have tagged the PR with one or more labels that reflect the pull request purpose.

@KrishnaSharma06 KrishnaSharma06 requested review from a team as code owners December 24, 2025 10:38
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @KrishnaSharma06, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the 'Tools' project by updating its GetCaseData action to utilize a new first-party API for retrieving case details. This change ensures the action remains current with the platform's API standards and is accompanied by necessary version increments for the 'Tools' project itself and its key internal dependencies.

Highlights

  • API Migration: The GetCaseData action within the 'Tools' project has been refactored to migrate its GetCaseFullDetails functionality to an updated first-party (1P) API, ensuring it leverages the latest API for fetching case overview details.
  • Version Updates: The 'Tools' project has been bumped to version 73.0. Additionally, its internal dependencies, TIPCommon and integration-testing, have been updated to version 2.2.21 across pyproject.toml and uv.lock files.
  • Release Notes: A new entry has been added to the release_notes.yaml file, documenting the refactoring of the 'Get Case Data' action for the updated API in version 73.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TIPCommon and integration-testing wheels and bumps the version for the Tools integration. The changes in pyproject.toml and uv.lock files are consistent. However, the main goal of migrating GetCaseFullDetails to a new 1P API in GetCaseData.py appears to be incomplete. A new helper function is imported but never used, leaving the old API call in place. This is a critical issue that needs to be addressed. Please see the specific comment for details on how to complete the implementation.

@KrishnaSharma06 KrishnaSharma06 self-assigned this Dec 24, 2025
@KrishnaSharma06 KrishnaSharma06 added Dependencies Pull requests that update a dependency file 1p updates Google Release Tools Tag for Tools integration New tipcommon labels Dec 24, 2025
TalShafir1
TalShafir1 previously approved these changes Jan 4, 2026
@himshikharr11 himshikharr11 merged commit a4d7e17 into main Jan 7, 2026
27 checks passed
@himshikharr11 himshikharr11 deleted the tools_get_case_full_details_migration branch January 7, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1p updates Dependencies Pull requests that update a dependency file Google Release New tipcommon Tools Tag for Tools integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants