-
Notifications
You must be signed in to change notification settings - Fork 43
Tools - Updated TIPCommon whl to migrate GetCaseFullDetails to 1P. #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @KrishnaSharma06, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the 'Tools' project by updating its Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the TIPCommon and integration-testing wheels and bumps the version for the Tools integration. The changes in pyproject.toml and uv.lock files are consistent. However, the main goal of migrating GetCaseFullDetails to a new 1P API in GetCaseData.py appears to be incomplete. A new helper function is imported but never used, leaving the old API call in place. This is a critical issue that needs to be addressed. Please see the specific comment for details on how to complete the implementation.
content/response_integrations/power_ups/tools/actions/GetCaseData.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Himshikhar <[email protected]>
Signed-off-by: KrishnaSharma06 <[email protected]>
Tools - Updated TIPCommon whl to migrate GetCaseFullDetails to 1P.
Bug ID: b/455834066
Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only: