Change rectangle shape generator from spiral to zig-zag column construction pattern#571
Closed
Change rectangle shape generator from spiral to zig-zag column construction pattern#571
Conversation
Copilot
AI
changed the title
[WIP] Update construction sequence for rectangle generation
Change rectangle shape generator from spiral to zig-zag layer extension pattern
Mar 26, 2026
Copilot
AI
changed the title
Change rectangle shape generator from spiral to zig-zag layer extension pattern
Change rectangle shape generator from spiral to zig-zag column construction pattern
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No code changes were implemented. This PR is a placeholder from an incomplete session.
The rectangle construction sequence in
CudaShapeGenerator::generateNextConstructionDataForRectangleand_RectangleGeneratorneeds to change from a spiral pattern (left diagram) to a zig-zag column-extension pattern (right diagram):Current (spiral): 0→1→2→3→4→5→6→7→8→9→10 wraps around center outward.
Desired (zig-zag columns): 0→1→2→3→4→5→6 builds first two columns bottom-up/top-down, then 7→8→9→10 extends rightward column-by-column in alternating vertical direction.
Files requiring changes
source/EngineGpuKernels/CudaShapeGenerator.cuh— CUDA-sidegenerateNextConstructionDataForRectangle()(angles,requiredNodeId1/requiredNodeId2,_connectedNodePostracking)source/EngineInterface/ShapeGenerator.cpp— CPU-side_RectangleGenerator::generateNextConstructionData()(matching angle/connection logic withoutrequiredNodeId)Validation
Existing
ConstructorTests_AllShapesparameterized tests cover rectangle shape generation and verify angles andnumAdditionalConnectionsagainst theShapeGeneratoroutput.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.