Skip to content

[WIP] Change rectangle shape generator from spiral to zig-zag column construction pattern#572

Closed
Copilot wants to merge 1 commit intodevelopfrom
copilot/change-construction-sequence-rectangle
Closed

[WIP] Change rectangle shape generator from spiral to zig-zag column construction pattern#572
Copilot wants to merge 1 commit intodevelopfrom
copilot/change-construction-sequence-rectangle

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

Change the rectangle construction sequence from a spiral pattern (wrapping outward from center) to a zig-zag column-extension pattern (building columns left-to-right with alternating vertical direction).

Status: Analysis only — no code changes implemented.

Desired Pattern

Current (spiral):          Desired (zig-zag):
9---10...                  4---5---6
|    |                     |   |   |
8---1---2                  3---2---7---10
|   |   |                  |   |   |    |
7---0---3                  0---1---8---9
|   |   |
6---5---4

Analysis

  • Angle sequence derived from diagram: 0, 90, 90, -90, -90, 0, -90, 0, 90, 90, 0, ... (spiral uses +90 for all turns)
  • numAdditionalConnections: 0, 0, 0, 1, 0, 1, 0, 1, 1, 0, 1, ...
  • Files requiring changes: CudaShapeGenerator.cuh (CUDA-side) and ShapeGenerator.cpp (CPU-side)

Remaining Work

  • Verify angle sign convention via ObjectDesc::getAngleSpan()
  • Determine vertical growth strategy (fixed height vs expanding)
  • Implement both CPU and CUDA generators with matching logic
  • Compute requiredNodeId1/requiredNodeId2 tracking for CUDA side
  • Validate against existing ConstructorTests_AllShapes parameterized tests

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI requested a review from chrxh March 26, 2026 08:43
Copilot stopped work on behalf of chrxh due to an error March 26, 2026 08:43
Copilot stopped work on behalf of chrxh due to an error March 26, 2026 10:15
Copilot AI changed the title [WIP] Update CudaShapeGenerator to use zig-zag pattern for rectangle construction [WIP] Change rectangle shape generator from spiral to zig-zag column construction pattern Mar 26, 2026
@chrxh chrxh closed this Mar 26, 2026
@chrxh chrxh deleted the copilot/change-construction-sequence-rectangle branch March 26, 2026 17:34
Copilot stopped work on behalf of chrxh due to an error March 26, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants