[WIP] Change rectangle shape generator from spiral to zig-zag column construction pattern#572
Closed
[WIP] Change rectangle shape generator from spiral to zig-zag column construction pattern#572
Conversation
Copilot stopped work on behalf of
chrxh due to an error
March 26, 2026 08:43
Copilot stopped work on behalf of
chrxh due to an error
March 26, 2026 10:15
Copilot
AI
changed the title
[WIP] Update CudaShapeGenerator to use zig-zag pattern for rectangle construction
[WIP] Change rectangle shape generator from spiral to zig-zag column construction pattern
Mar 26, 2026
Copilot stopped work on behalf of
chrxh due to an error
March 26, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the rectangle construction sequence from a spiral pattern (wrapping outward from center) to a zig-zag column-extension pattern (building columns left-to-right with alternating vertical direction).
Status: Analysis only — no code changes implemented.
Desired Pattern
Analysis
0, 90, 90, -90, -90, 0, -90, 0, 90, 90, 0, ...(spiral uses+90for all turns)0, 0, 0, 1, 0, 1, 0, 1, 1, 0, 1, ...CudaShapeGenerator.cuh(CUDA-side) andShapeGenerator.cpp(CPU-side)Remaining Work
ObjectDesc::getAngleSpan()requiredNodeId1/requiredNodeId2tracking for CUDA sideConstructorTests_AllShapesparameterized tests✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.