Revert rectangle generator to original spiral pattern for reimplementation#573
Closed
Revert rectangle generator to original spiral pattern for reimplementation#573
Conversation
… pattern Co-authored-by: chrxh <73127001+chrxh@users.noreply.github.com> Agent-Logs-Url: https://github.com/chrxh/alien/sessions/ca44db6a-0065-449a-9fe8-437098eaf6f7
Copilot
AI
changed the title
[WIP] Update rectangle construction pattern to zig-zag column-extension
Change rectangle construction from spiral to zig-zag column-extension pattern
Mar 26, 2026
Owner
|
@copilot your changes are wrong. 0 → (0, 0) With the new zig-zag construction it should be: |
…ation Agent-Logs-Url: https://github.com/chrxh/alien/sessions/918101f8-8078-477e-a1a5-f0310b1398a9 Co-authored-by: chrxh <73127001+chrxh@users.noreply.github.com>
Copilot
AI
changed the title
Change rectangle construction from spiral to zig-zag column-extension pattern
Revert rectangle generator to original spiral pattern for reimplementation
Mar 26, 2026
Owner
|
@copilot continue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous zig-zag rectangle construction implementation produced incorrect cell positions. The reviewer provided the correct expected zig-zag traversal order:
This commit reverts
CudaShapeGenerator.cuhandShapeGenerator.cppback to the original spiral pattern. The correct zig-zag angle sequence has been derived (alternating ±90° turns with straight segments) but is not yet implemented.Status: incomplete. The correct algorithm still needs to be implemented in a follow-up.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.