Skip to content

[WIP] Change rectangle construction pattern to zig-zag#575

Closed
Copilot wants to merge 1 commit intodevelopfrom
copilot/update-rectangle-construction-pattern-again
Closed

[WIP] Change rectangle construction pattern to zig-zag#575
Copilot wants to merge 1 commit intodevelopfrom
copilot/update-rectangle-construction-pattern-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

The rectangle construction sequence in CudaShapeGenerator::generateNextConstructionDataForRectangle and _RectangleGenerator needs to change from a spiral pattern to a zig-zag column-extension pattern:

Before the rectangle construction had the positions (wraps around center outward): 0 → (0, 0) 1 → (0, 1) 2 → (1, 1) 3 → (1, 0) 4 → (1, -1) 5 → (0, -1) 6 → (-1, -1) 7 → (-1, 0) 8 → (-1, 1) 9 → (-1, 2) 10 → (0, 2) ....

With the new zig-zag construction it should be: 0 → (0, 0) 1 → (1, 0) 2 → (1, 1) 3 → (0, 1) 4 → (0, 2) 5 → (1, 2) 6 → (2, 2) 7 → (2, 1) 8 → (2, 0) 9 → (3, 0) 10 → (3, 1)

Files requiring changes source/EngineGpuKernels/CudaShapeGenerator.cuh — CUDA-side generateNextConstructionDataForRectangle() (angles, requiredNodeId1/requiredNodeId2, _connectedNodePos tracking) source/EngineInterface/ShapeGenerator.cpp — CPU-side _RectangleGenerator::generateNextConstructionData() (matching angle/connection logic without requiredNodeId) Validation Existing ConstructorTests_AllShapes parameterized tests cover rectangle shape generation and verify angles and numAdditionalConnections against the ShapeGenerator output.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI requested a review from chrxh March 26, 2026 21:43
Copilot stopped work on behalf of chrxh due to an error March 26, 2026 21:43
@chrxh chrxh closed this Mar 26, 2026
@chrxh chrxh deleted the copilot/update-rectangle-construction-pattern-again branch March 26, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants