Support Dependency Range - #153
Merged
Merged
Conversation
nightlark
reviewed
Mar 17, 2026
| "overrides>=7.7.0,<8", | ||
| "pillow>=10.4,<11", | ||
| "ply>=3.11,<4", | ||
| "pyfiglet>=1.0,<2", |
There was a problem hiding this comment.
Suggested change
| "pyfiglet>=1.0,<2", | |
| "pyfiglet>=1.0,<2; python_version >= '3.9", |
pyfiglet 1.x releases only support Python 3.9 and newer, so it could be changed to only be used in those cases... however searching through the code, I'm not seeing pyfiglet used anywhere? It appears to be a dependency of asciimatics, which I'm also not seeing imported in pyfx. And same for pillow (searched for PIL didn't turn up any imports in pyfx).
I might be overlooking something though.
nightlark
reviewed
Mar 17, 2026
There was a problem hiding this comment.
An alternative to adding a python version constraint to pyfiglet would be just bumping this up to a newer version and removing the CI tests for the older Python versions, since Python 3.8 is EOL (and 3.9 is too as of October 2025).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.