Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify report colors for 508 compliance #1445

Closed
wants to merge 16 commits into from
Closed

Modify report colors for 508 compliance #1445

wants to merge 16 commits into from

Conversation

ehaines1
Copy link
Collaborator

@ehaines1 ehaines1 commented Nov 27, 2024 •
edited
Loading

Tweak link colors in dark theme to comply with 508

🗣 Description

💭 Motivation and context

The links in the heading of the AAD report with the dark theme set were difficult to read. They also did not meet 508 requirements for color contrast.
Closes #1349

🧪 Testing

To test this, I downloaded a tool called axe (free version) and ran a full-page scan, which showed which elements were non-compliant.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

amart241 and others added 16 commits November 7, 2024 11:40
@amart241 @schrolla
Add demo requirement to PR template pre-approval checklist (#1378)
3d0ad4d 
* Update pull_request_template.md

Added a demo checkbox so that any change medium or higher will have to have a formal demo showing code changes and functional changes.

* Update .github/pull_request_template.md

Suggested change

Co-authored-by: Addam Schroll <[email protected]>

---------

Co-authored-by: Addam Schroll <[email protected]>
@buidav
Update Module Version Bump Action to target the new documentation (#1373
c7d5e41 
)

* save current progress

* forgot to save

* add new line

* commit this for now

* add changes and unit tests from fork

* add input/error validation suggestion from review

* replace write-host

* appease Checkov
@james-garriss
Change mechanism for calling PSSA (#1375)
cf2084e 
* use built in job

* switch to linux

* fix psd path

* cp to workflow dir

* fix github path

* fix path again

* fix path more again

* temp remove excludes

* revert excludes

* use ms version

* return to ML for now

* use script

* fix path to settings

* add write host

* Remove write host test

* comment

* get version

* get version

* get version

* get version

* list modules

* get version

* get just version

* get version and name

* Get name and version

* move to end

* clean up code.

* check more file extensions

* list files

* fix filename

* write files

* comment files

* set debugging flag for Addam

* test debug for Addam

* set back to false

* replace pssa workflow code

* tweak code

* fix operator

* improve loop structure

* change color

* remove param

* Use count, add sum

* fix color

* Move debugging

* improve install

* final edits

* add ::error:: for annotations

* add intentional problem

* put ::error:: on message

* put ::error:: at better place

* Prevent annotation for info

* REmove intentional err

* convert to function

* Call the function with param

* add write-host

* source the function

* use function name

* fix source path

* add path

* fix repopath

* remove dupe recurse

* debug

* debug

* debug

* fix path

* fix config path

* cat files

* mod repo path

* hardcode path

* debug path

* debug

* debug

* debug

* debug

* debug

* debug

* debug

* fix dupe name

* rewrite

* add missing }

* format

* cleanup

* more cleanup

* fix comments and remove errors

* fix lint

* nuke the nitpick
@buidav
fix the long lines (#1386)
1e69fea
@dagarwal-mitre @tkol2022
Adding Conditional Access Policy Implementation Instructions to AAD 1…
4f4233c 
….1 (#1312)

* changes to 1.1 instructions

* removed link

* added numbers to make more consistent

* Update PowerShell/ScubaGear/baselines/aad.md

Co-authored-by: Ted Kolovos <[email protected]>

---------

Co-authored-by: Ted Kolovos <[email protected]>
@ahuynhMITRE @schrolla
Update Front Matter across SCBs and specific language in the Defender…
63b0dec 
… SCB to match OCC approved language (#1398)

* Update defender.md

* Update aad.md

* Update exo.md

* Update aad.md

* Update defender.md

* Update powerbi.md

* Update powerplatform.md

* Update sharepoint.md

* Update teams.md

* Update removedpolicies.md

* added note to 6.3v1 on how to view and export logs that do not require G5 or E5

* added resources and note for audit retention.

* added note into the license requirement section

* formatting

* formatting

* Update PowerShell/ScubaGear/baselines/defender.md

Co-authored-by: Addam Schroll <[email protected]>

* Update section 7 license requirements

* Update group 6 license requirement section

* Update defender section 4 license requirements section.

---------

Co-authored-by: Addam Schroll <[email protected]>
@ahuynhMITRE
Update incorrect hyperlinks in SCB markdown (#1413)
39b17c1 
* Update T1078 attack link

* Update T1213.002 link
@james-garriss
Improve functional test notifications (#1401)
5987051 
* write email

* fixed runs-on

* create link

* add notify

* fix secrets

* fix to

* fix yaml

* email on fail

* both pass

* both fail

* move email to its own job

* add debugging

* enable EntraID

* enable all the rest

* checkout repo for email

* fix repo path for checkout

* fix path again

* run email on windows

* clean up commenting

* remove test file

* remove comments
@tkol2022
improve performance query to get count of users without advanced audi…
3d336bc 
…ting enabled (#1406)
@james-garriss @schrolla
Correct omission in documentation about importing module when downloa…
fb64ab5 
…ding from GitHub (#1412)

* add import

* remove cloning

* fix -name error

* Update docs/execution/execution.md

Co-authored-by: Addam Schroll <[email protected]>

* Update docs/installation/github.md

Co-authored-by: Addam Schroll <[email protected]>

---------

Co-authored-by: Addam Schroll <[email protected]>
@james-garriss
Update schedule for functional test workflow (#1428)
0fd5401 
* update cron schedule

* fix spelling
@ehaines1
Add service principal setup to functional testing documentation (#1423)
961a74d 
* amended Testing Readme with sections for issue links

* changed titles of additional markdown docs for consistency

* changed content to conform to Content Guide

* changed titles of additional markdown docs for consistency

* tweaks in titles and file names

* refined titles for documents

* fixed name of link
@github-actions @actions-user
Bump OPA version from v0.69.0 to v0.70.0 (#1395)
a6b2cbe 
Co-authored-by: GitHub Action <[email protected]>
@james-garriss
Convert workflow testing code to functions (#1430)
afc948d 
* Convert modules to functions

* fix lint

* source functions

* fix source typo

* fix repo path

* fix source path for pester test
@adhilto @buidav @mitchelbaker-cisa
Add the report UUID to the ScubaResults.json filename (#1426)
77dc279 
* Initial implementation of adding UUID to the file name

* Add back missing ConvertFrom-Json call

* Mock Get-ChildItem in unit tests

* Document addition of UUID to ScubaResults file name

* Add unit tests for when there are multiple ScubaResults*.json files

* Correct minor typo in documentation

* remove wildcard search in ConvertTo-ResultsCSV code path

* add error handling of window path length limit errors

* fix some of the tests

* fix the all the current broken unit tests

* additional unit tests

* add back in accidentally removed fields in config

* complete lorem ipsum

* todo message

* remove UUID truncation for now

* first draft

* add truncation param to documenatation

* spacing

* fix failing test cases; handle full truncation case

* make code consistent; add code comments to describe it's purpose

* review feedback; point to additional options in the error message

* PR Review: Fix absolute path check; fix config file override

* review feedback; move new parameter in alphabetical order in docs

* keep documentation consistent

* remove configuration paramset from scubacached

* code comments for the new edge case

* Remove OBE unit test

* Remove duplicate word

* fix typos, wording and formatting in config

* Refactor truncation logic into own function

* rm duplicate text from PowerShell as well

* captialize

* remove long path check let the set-content naturally error out

* add long path error check within the catch block

* remove todo

* Add UUID to mock data for cached tests

* Fix unit tests

* Remove commented out validation code.

Co-authored-by: mitchelbaker-cisa <[email protected]>

* add validation set to check invalid config file parameter

* Remove stacktrace

---------

Co-authored-by: buidav <[email protected]>
Co-authored-by: mitchelbaker-cisa <[email protected]>
@adhilto @mitchelbaker-cisa
Clarify License Requirements in assumptions.md (#1439)
4b68176 
* Update assumptions.md license requirements language 

* Add Defender plan 2

---------

Co-authored-by: mitchelbaker-cisa <[email protected]>
@ehaines1 ehaines1 added the enhancement This issue or pull request will add new or improve existing functionality label Nov 27, 2024
@ehaines1 ehaines1 added this to the Kraken milestone Nov 27, 2024
@ehaines1 ehaines1 self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhilto adhilto Awaiting requested review from adhilto

@mitchelbaker-cisa mitchelbaker-cisa Awaiting requested review from mitchelbaker-cisa

Assignees

@ehaines1 ehaines1

Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ehaines1 @adhilto @nanda-katikaneni @schrolla @amart241 @buidav @james-garriss @dagarwal-mitre @ahuynhMITRE @tkol2022