Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to MS.SHAREPOINT.1.4v1 across the repo #1593

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ahuynhMITRE
Copy link
Collaborator

🗣 Description

Removal of MS.SHAREPOINT.1.4v1 across the SCBs and GitHub repo due to depricated functionality from Microsoft.

💭 Motivation and context

Change is required since the ability to configure the control has been deprecated by Microsoft.
Closes #1560

🧪 Testing

Validated MS.SHAREPOINT.1.4v1 was removed from the SCBs as well as unit and functional tests.
MS.SHAREPOINT.1.4v1 was added to the removedpolicies.md file
ScubaGear runs as expected and generates an HTML report with no errors or warnings and does not include the old policy check results.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@ahuynhMITRE ahuynhMITRE added baseline-document Issues relating to the text in the baseline documents themselves code-review This issue or task involves reviewing the code for the assigned script labels Feb 24, 2025
@ahuynhMITRE ahuynhMITRE added this to the Marlin milestone Feb 24, 2025
@ahuynhMITRE ahuynhMITRE self-assigned this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baseline-document Issues relating to the text in the baseline documents themselves code-review This issue or task involves reviewing the code for the assigned script
Projects
None yet
1 participant