MS.TEAMS.5.xv1 - update warning message to reflect the correct reason for the policy fail (public reported issue)

[nanda-katikaneni]

🗣 Description

Teams policies MS.TEAMS.5.1v1 - MS.TEAMS.5.3v1 deals with application permission policies - in case of a failure ScubaGear generates a warning message (since this is a SHOULD policy). Currently the warning message correctly identifies the offending policies but incorrectly indicates them as meeting policies. This PR is to change warning message to correctly identify them as app permission policies.

💭 Motivation and context

Closes #1495

🧪 Testing

Run ScubaGear against a tenant. Configure the tenant to fail the TEAMS.5.1v1. Make sure that the scubagear results report correctly identifies the result for 5.1 and the warning message correctly identifies the offending 'app permission policy'.

Warning message before the fix:

Warning message after the fix:

✅ Pre-approval checklist

• This PR has an informative and human-readable title.
• PR targets the correct parent branch (e.g., main or release-name) for merge.
• Changes are limited to a single goal - eschew scope creep!
• Changes are sized such that they do not touch excessive number of files.
• All future TODOs are captured in issues, which are referenced in code comments.
• These code changes follow the ScubaGear content style guide.
• Related issues these changes resolve are linked preferably via closing keywords.
• All relevant type-of-change labels added.
• All relevant project fields are set.
• All relevant repo and/or project documentation updated to reflect these changes.
• Unit tests added/updated to cover PowerShell and Rego changes.
• Functional tests added/updated to cover PowerShell and Rego changes.
• All relevant functional tests passed.
• All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

• PR passed smoke test check.

• Feature branch has been rebased against changes from parent branch, as needed

  Use Rebase branch button below or use this reference to rebase from the command line.

• Resolved all merge conflicts on branch

• Notified merge coordinator that PR is ready for merge via comment mention

• Demonstrate changes to the team for questions and comments.
  (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

• Feature branch deleted after merge to clean up repository.
• Verified that all checks pass on parent branch (e.g., main or release-name) after merge.