Save omitted rego evaulation results #1604
Open
+294
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Save what the result would have been for controls that are omitted if they had not been omitted to the JSON output (HTML output is unchanged). Two new keys are added for each test result:
OmittedEvaluationResult
: What the result would have been, e.g., "Fail"OmittedEvaluationDetails
: What the report details string would have been, e.g., "1 agency domain(s) found in violation: example.com"For tests that are not omitted, those keys will be set to "N/A". See screenshot below for an example.
💭 Motivation and context
Closes #1458.
🧪 Testing
OmittedEvaluationResult
andOmittedEvaluationDetails
values are correct for the omitted control.OmittedEvaluationResult
andOmittedEvaluationDetails
values are "N/A" for the controls that were not omitted.📷 Screenshots (if appropriate)
New keys indicated in red:

✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist