Skip to content

Update GWS.CLASSROOM.1.2 and 1.2 #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update GWS.CLASSROOM.1.2 and 1.2 #802

wants to merge 3 commits into from

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Oct 14, 2025

🗣 Description

  • Update the baseline so that "in allowlisted domains" is a valid choice for Classroom 1.1 and 1.2.
  • Update the Rego to reflect that change

💭 Motivation and context

Closes #796.

🧪 Testing

  • Updated unit tests
  • Manually tested, ensured that only the "in your domain" or "in allowlisted domains" options passes

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added this to the Guppy milestone Oct 14, 2025
@adhilto adhilto self-assigned this Oct 14, 2025
@adhilto adhilto added baseline-document Issues relating to the text in the baseline documents themselves Baseline Code Implementation A code change for baseline updates on the release branch during a baseline freeze. labels Oct 14, 2025
@adhilto adhilto linked an issue Oct 14, 2025 that may be closed by this pull request
Reassess GWS.CLASSROOM.1.1 and 1.2 #796
Open
4 tasks
dagarwal-ecs
dagarwal-ecs approved these changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@dagarwal-ecs dagarwal-ecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the less restrictive verbiage

@adhilto adhilto force-pushed the 796-reassess-gwsclassroom11-and-12 branch from f2cda30 to 5ea9f9d Compare October 17, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dagarwal-ecs dagarwal-ecs dagarwal-ecs approved these changes

@ahuynhECS ahuynhECS Awaiting requested review from ahuynhECS

At least 2 approving reviews are required to merge this pull request.

Assignees

@adhilto adhilto

Labels

Baseline Code Implementation A code change for baseline updates on the release branch during a baseline freeze. baseline-document Issues relating to the text in the baseline documents themselves

Projects

None yet

Milestone

Guppy

Development

Successfully merging this pull request may close these issues.

Reassess GWS.CLASSROOM.1.1 and 1.2

2 participants

@adhilto @dagarwal-ecs