Skip to content

Conversation

@DJensen94
Copy link
Contributor

Add Was finding model and a scan to sync findings

🗣 Description

This scan loops through all the orgs and attempts to query WAS findings from the DMZ for each. It saves all findings to the mini datalake.

💭 Motivation and context

This allows us to get Qualys WAS data for each of our stakeholders who receive WAS scans

🧪 Testing

Tested scan and model creation locally, it successfully moves past organizations that don't have findings and saves the appropriate data to the new model table.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Add Was finding model and a scan to sync findings
Run linter
switch un-reassigned let variables
run audit fix
update package-lock via npm audit
frontend npm audit fix
@schmelz21 schmelz21 requested a review from lwersiy August 7, 2024 14:55
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to up our game on logging by using log levels. We only have console logs and error logs. We should have at least 5 different levels (info, warn, error, debug, all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants