Install via official package repository for Ubuntu#76
Open
jsf9k wants to merge 3 commits into
Open
Conversation
jsf9k
added
the
improvement
The aws/efs-utils folks now offer a package repo with pre-built *.debs, but only for Ubuntu. See aws/efs-utils#111 for more details.
jsf9k
force-pushed
the
improvement/use-prebuilt-ubuntu-packages
branch
from
db84328 to
d545691
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the role’s Ubuntu installation path to use AWS’s hosted APT repository for amazon-efs-utils instead of building .deb packages from source, aligning with upstream’s newly available prebuilt packages for supported Ubuntu releases.
Changes:
- Removed Ubuntu Jammy-specific build-from-source variables.
- Added Ubuntu-specific install tasks to add the AWS
efs-utilsAPT repo and installamazon-efs-utils. - Added a handler intended to refresh the package cache.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| vars/Ubuntu_jammy.yml | Removes Jammy build-from-source variables now that Ubuntu installs via repo. |
| tasks/install_Ubuntu.yml | Adds the AWS APT repo and installs amazon-efs-utils on Ubuntu. |
| handlers/main.yml | Introduces a package-cache update handler used by the Ubuntu install flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+27
| - name: Add the official aws/efs-utils repo | ||
| ansible.builtin.deb822_repository: | ||
| components: | ||
| - main | ||
| name: efs-utils | ||
| signed_by: https://amazon-efs-utils.aws.com/efs-utils-armored.gpg | ||
| suites: | ||
| - "{{ ansible_facts['distribution_version'] }}" | ||
| uris: | ||
| - >- | ||
| https://amazon-efs-utils.aws.com/repo/deb/ubuntu/{{ | ||
| ansible_facts['distribution_version'] }} | ||
| notify: | ||
| - Update the package cache | ||
|
|
||
| # We need the handler that updates the apt package cache to run | ||
| # now if it is necessary. | ||
| - name: Flush handlers | ||
| ansible.builtin.meta: flush_handlers |
Member
Author
There was a problem hiding this comment.
ansible-lint will complain about the suggested solution since it wants tasks that run on change to be in handlers.
Comment on lines
+10
to
+16
| ansible.builtin.deb822_repository: | ||
| components: | ||
| - main | ||
| name: efs-utils | ||
| signed_by: https://amazon-efs-utils.aws.com/efs-utils-armored.gpg | ||
| suites: | ||
| - "{{ ansible_facts['distribution_version'] }}" |
Comment on lines
+2
to
+4
| - name: Update the package cache | ||
| ansible.builtin.package: | ||
| update_cache: true |
Member
Author
There was a problem hiding this comment.
I'd prefer to keep the functionality generic here, in the event that aws/efs-utils ever offers pre-built packages for, e.g., RedHat platforms
github-actions
Bot
added
the
dependencies
We use ansible.builtin.deb822_repository in this role (for Ubuntu), and this module was introduced in ansible-core 2.15.
jsf9k
force-pushed
the
improvement/use-prebuilt-ubuntu-packages
branch
from
5957746 to
f824239
Compare
We no longer build the deb packages for Ubuntu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the role to install on Ubuntu via the official package repository.
💭 Motivation and context
The aws/efs-utils folks now offer a package repository with pre-built
*.debs, but currently only for Ubuntu 22.04 and 24.04. We may as well use these packages to save us the time, effort, and heartache of building the packages from source.🧪 Testing
All automated tests pass.
✅ Pre-approval checklist