Skip to content

Conversation

itsmostafa
Copy link
Collaborator

@itsmostafa itsmostafa commented Oct 9, 2025

This pull request introduces significant enhancements to the assessment export data model, particularly by expanding demographic and organizational information, improving the structure of standards and questions, and adding support for CIS-specific demographics. It also includes some backend adjustments to support these new data structures and fields.

Export Model Enhancements:

  • Major redesign of AssessmentJson to include a new OrganizationInfoJson class, encapsulating detailed organization, sector, and compliance information. Added new fields such as AssessorWorkflow and FacilitatorName, and moved or expanded several demographic properties.
  • Introduced new classes for SAL (Security Assurance Level) data (SalJson), and restructured standards/question export to support both requirements and questions mode, including subcategory groupings (StandardQuestionSubCategoryJson).
  • Added new comment and answer text fields to MaturityQuestionJson, RequirementJson, and StandardQuestionJson for clearer export of assessment responses. [1] [2] [3]
  • Extended ObservationJson with new fields such as Importance, Summary, Impacts, Vulnerabilities, and AutoGeneratedBy for richer reporting.
  • Added a new ComponentQuestionJson class for component-level question exports.

CIS Demographics Support:

  • Introduced a comprehensive set of CIS-specific demographic classes (CisDemographicsJson, CisServiceDemographicsJson, CisOrganizationDemographicsJson, CisServiceCompositionJson) and an AssessmentExportPayload container to facilitate export and serialization of all assessment data, including CIS extensions.
  • Registered ICisDemographicBusiness in the DI container to support new CIS demographic features in the backend.

Demographic Data Improvements:

  • Added CriticalServiceName to both the DemographicExt model and its business logic, enabling export of this key data point. [1] [2]
  • Improved how sector and industry IDs are assigned to assessments by simplifying and centralizing the demographic data fetch logic.
  • Refined facilitator assignment logic to use the updated demographic data structure.

These changes collectively enable richer, more organized, and extensible export of assessment and demographic data, supporting both standard and CIS-specific workflows.

@itsmostafa itsmostafa self-assigned this Oct 9, 2025
@itsmostafa itsmostafa marked this pull request as ready for review October 9, 2025 19:11
@itsmostafa itsmostafa marked this pull request as draft October 9, 2025 19:14
@itsmostafa itsmostafa marked this pull request as ready for review October 15, 2025 02:20
@randywoods randywoods merged commit fa1216c into develop Oct 15, 2025
6 checks passed
@randywoods randywoods deleted the feature/modify-json-export branch October 15, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants