Skip to content

⚠️ CONFLICT! Lineage pull request for: skeleton#207

Draft
cisagovbot wants to merge 46 commits into
developfrom
lineage/skeleton
Draft

⚠️ CONFLICT! Lineage pull request for: skeleton#207
cisagovbot wants to merge 46 commits into
developfrom
lineage/skeleton

Conversation

@cisagovbot
Copy link
Copy Markdown

Lineage Pull Request: CONFLICT

Achtung!!!

Lineage has created this pull request to incorporate new changes found in an upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-packer.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with your project.

The lineage/skeleton branch has one or more unresolved merge conflicts that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/kali-packer.git kali-packer
    cd kali-packer
    git remote add skeleton https://github.com/cisagov/skeleton-packer.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the branch, commit, and push your changes:

    git add version.txt 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message that git creates for you, but please do not delete the existing content. It provides useful information about the merge that is being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

Remove any of the following that do not apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • ✌️ The conflicts in this pull request have been resolved.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

Remove any of the following that do not apply. These boxes should remain unchecked until the pull request has been approved.

  • Finalize version.

✅ Post-merge checklist

Remove any of the following that do not apply.

  • Create a release (necessary if and only if the version was bumped).

Note

You are seeing this because one of this repository's maintainers has configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

dependabot Bot and others added 30 commits March 2, 2026 20:23
Bumps [crazy-max/ghaction-github-labeler](https://github.com/crazy-max/ghaction-github-labeler) from 5 to 6.
- [Release notes](https://github.com/crazy-max/ghaction-github-labeler/releases)
- [Commits](crazy-max/ghaction-github-labeler@v5...v6)

---
updated-dependencies:
- dependency-name: crazy-max/ghaction-github-labeler
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 3 to 4.
- [Release notes](https://github.com/hashicorp/setup-terraform/releases)
- [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md)
- [Commits](hashicorp/setup-terraform@v3...v4)

---
updated-dependencies:
- dependency-name: hashicorp/setup-terraform
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
This warning contradicts the Black style so it must be ignored.
Make the ignore commenting consistent with the select commenting. Break
up each comment/directive with an empty line.
This adds the flake8-bugbear plugin to our pre-commit configuration.
Note that flake8 is already configured to use this plugin's warnings.
Add the dlint plugin to our flake8 configuration for pre-commit. Update
the flake8 configuration to select these new warnings.
Add the flake8-noqa plugin to the flake8 portion of our pre-commit
configuration. Update the flake8 configuration to select these new
warnings.
Add the pep8-naming plugin to the flake8 portion of our pre-commit
configuration. Update the flake8 configuration to select these new
warnings.
Add the flake8-comprehensions plugin to the flake8 portion of our
pre-commit configuration. Update the flake8 configuration to select
these new warnings.
When explaining the items selected or ignored in the configuration we
now preface each line with the prefix/code it pertains to in the
configuration. Also break apart the pycodestyle prefixes into their own
lines.
The `go-critic` pre-commit hook from the TekWizely/pre-commit-golang
repo expects the binary to be called `go-critic` now. As a result, the
current tool installation in the `build.yml` workflow results in the
following error when pre-commit is run in GitHub Actions:
error: command not found: go-critic
The file is not used to configure anything bandit does by default so we
can safely remove it and updated the pre-commit configuration. This is
also acceptable because the configuration file has been removed
downstream in cisagov/skeleton-python-library already.
Mention the specific role that makes use of
community.general.json_query to make it easier for the user to
determine whether the jmespath Python dependency is necessary.
Correct grammar
Change two reference URLs in the flake8 configuration to use `https://`
instead of `http://`.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Change a reference URL in the flake8 configuration because
`pydocstyle.org` domain ownership appears to have lapsed. Instead point
to the source file in the archived GitHub repository.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Attribute the error codes we are ignoring to the correct source
package.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This extends our usage of the antonbabenko/pre-commit-terraform hook
collection. This new hook will automatically ensure that a Terraform
lock file includes hashes for all of our supported platforms.
It is not necessary to use `--force-with-deps` when running in GitHub
Actions (i.e. in the CLI code) because there we are starting from a
known, pristine state.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
We have to ignore this vulnerability for now since an update for
pygments has not yet been released.

In any event, this vulnerability is unlikely to cause us any problems
since we don't feed any regexes to pygments directly.

See also:
- cisagov/skeleton-generic#257
- https://nvd.nist.gov/vuln/detail/CVE-2026-4539
- pygments/pygments#3058

Co-authored-by: Nick M <50747025+mcdonnnj@users.noreply.github.com>
Ignore a vulnerability originating from `pygments`
…orp/setup-terraform-4

Bump hashicorp/setup-terraform from 3 to 4
…max/ghaction-github-labeler-6

Bump crazy-max/ghaction-github-labeler from 5 to 6
This is done automatically with the pre-commit autoupdate command.
Newer versions of the hook require Python 3.14, but we are still using
Python 3.13 in our GitHub Actions configuration.
Install the `go-critic` command instead of `gocritic` in the `build.yml` workflow
…uration

Add additional plugins to the `flake8` pre-commit configuration
…to_lock_terraform_providers

Add a pre-commit hook to lock Terraform providers automatically
mcdonnnj and others added 16 commits March 25, 2026 15:40
…uration_file

Remove the bandit configuration file
…cheme

The legacy account names are finally going away, so we can now use a more specific regex to match account names.
Bumps the aws-provider group with 1 update in the /terraform-build-user directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws).
Bumps the aws-provider group with 1 update in the /terraform-post-packer directory: [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws).


Updates `hashicorp/aws` from 6.35.1 to 6.47.0
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.35.1...v6.47.0)

Updates `hashicorp/aws` from 6.35.1 to 6.47.0
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.35.1...v6.47.0)

Updates `hashicorp/aws` from 6.35.1 to 6.47.0
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.35.1...v6.47.0)

Updates `hashicorp/aws` from 6.35.1 to 6.47.0
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.35.1...v6.47.0)

---
updated-dependencies:
- dependency-name: hashicorp/aws
  dependency-version: 6.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-provider
- dependency-name: hashicorp/aws
  dependency-version: 6.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-provider
- dependency-name: hashicorp/aws
  dependency-version: 6.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-provider
- dependency-name: hashicorp/aws
  dependency-version: 6.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-provider
...

Signed-off-by: dependabot[bot] <support@github.com>
…ce-with-deps

Explain why we use `--force-with-deps` when running Packer manually
…uild-user/aws-provider-e176355a5d

Bump the aws-provider group across 2 directories with 1 update
Update default value of `ami_share_account_name_regex` to match current assessment account naming scheme
⚠️ CONFLICT! Lineage pull request for: skeleton
@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Jun 3, 2026
@github-actions github-actions Bot added documentation This issue or pull request improves or adds to documentation version bump This issue or pull request increments the version number dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code github-actions Pull requests that update GitHub Actions code test This issue or pull request adds or otherwise modifies test code labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation This issue or pull request improves or adds to documentation github-actions Pull requests that update GitHub Actions code terraform Pull requests that update Terraform code test This issue or pull request adds or otherwise modifies test code upstream update This issue or pull request pulls in upstream updates version bump This issue or pull request increments the version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants