-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the cloudflare rotation instructions [no sandbox] #3381
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, it makes me happy to see these sorts of tickets. Thanks for making these changes.
See the two minor grammatical suggestions, though not blocking the approval on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of suggestions but good as is!
@@ -1,7 +1,7 @@ | |||
# HOWTO Rotate the Application's Secrets | |||
======================== | |||
|
|||
Secrets are read from the running environment. | |||
Below you will find sections for each of the application secrets which can & will be changed individual and expire at different times. Secrets are read from the running environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
individually
?
|
||
## REGISTRY_CERT and REGISTRY_KEY and REGISTRY_KEY_PASSPHRASE | ||
## Rotating REGISTRY_CERT and REGISTRY_KEY and REGISTRY_KEY_PASSPHRASE for Cloudflare environments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the Cloudflare hosted registry
maybe?
Co-authored-by: zandercymatics <[email protected]>
Co-authored-by: zandercymatics <[email protected]>
Ticket
Resolves #00
Changes
Context for reviewers
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots