-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2906: ADR explaining our Ajax use on dynamic forms #3546
Conversation
🥳 Successfully deployed to developer sandbox rjm. |
1 similar comment
🥳 Successfully deployed to developer sandbox rjm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rachid you make me look bad, couldn't find a single typo or main point you missed. At least throw me a bone.
Looks perfect approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
**Option 3:** Use a Lightweight JavaScript Framework (e.g., HTMX, HTMZ) | ||
Instead of React or Vue, this approach involves using a minimal JavaScript framework like HTMX or HTMZ to enhance interactivity while preserving Django’s server-rendered structure. | ||
|
||
✅ Pros: | ||
- Reduces the need for a full rewrite. | ||
- Keeps Django templates largely intact. | ||
- Minimizes complexity compared to React or Vue. | ||
|
||
❌ Cons: | ||
- Limited community support and long-term viability concerns. | ||
- Still introduces new technology and learning curves. | ||
- Unclear whether it fully meets our interactivity needs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
🥳 Successfully deployed to developer sandbox rjm. |
🥳 Successfully deployed to developer sandbox rjm. |
🥳 Successfully deployed to developer sandbox rjm. |
🥳 Successfully deployed to developer sandbox rjm. |
Ticket
Resolves #2906
Changes
Context for reviewers
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots