-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3484: Update export CSV to match permission language changes [ES] #3566
base: main
Are you sure you want to change the base?
Conversation
🥳 Successfully deployed to developer sandbox es. |
🥳 Successfully deployed to developer sandbox es. |
@@ -38,10 +38,18 @@ | |||
from django.contrib.contenttypes.models import ContentType | |||
from registrar.models.utility.generic_helper import convert_queryset_to_dict | |||
from registrar.models.utility.orm_helper import ArrayRemoveNull | |||
from registrar.models.utility.portfolio_helper import UserPortfolioRoleChoices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work
🥳 Successfully deployed to developer sandbox es. |
Ticket
Resolves #3484
Changes
Updates Members CSV export with the following:
Organization admin
field toMember access
. Change field from boolean to access level string.Context for reviewers
Setup
In the org model view, export the Members CSV from the Members page. Verify that the CSV matches the changes described above.
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots