#3181 - dynamic labels for investigator and senior official [-Bob] #3577

CocoByte · 2025-02-27T01:29:08Z

Ticket 3181

Resolves #3181

Changes

Added overrides that target select2 dropdowns and add aria-describedby text in accordance with the ticket's ACs.

Context for reviewers

The two dropdowns listed in the original ACs really just highlight a more systemic issue with our ARIA labels for select2 dropdowns. The updates for this ticket addresses all select2 components throughout Django Admin so they will all follow the same pattern.

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Verified code meets all checks above. Address any checks that are not satisfied
Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
Checked that all code is adequately covered by tests
Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
(Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior. Comment any found issues or broken flows.
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user

References

Code review best practices

Screenshots

zandercymatics

Just needs some cleanup, but everything is here! I like how you are addressing this holistically, which is a very nice touch

src/registrar/admin.py

src/registrar/assets/src/js/getgov-admin/andi.js

src/registrar/templates/django/admin/includes/detail_table_fieldset.html

src/registrar/assets/src/js/getgov-admin/andi.js

Co-authored-by: zandercymatics <[email protected]>

github-actions · 2025-02-28T19:02:12Z

🥳 Successfully deployed to developer sandbox nl.

…fficial

github-actions · 2025-03-01T00:24:25Z

🥳 Successfully deployed to developer sandbox nl.

…fficial

github-actions · 2025-03-03T18:09:48Z

🥳 Successfully deployed to developer sandbox nl.

src/registrar/assets/src/js/getgov-admin/andi.js

rachidatecs · 2025-03-04T00:42:58Z

Note for @zandercymatics and @CocoByte, I only did a skim on this one

…fficial

…and-senior-official' into nl/3181-labels-for-investigator-and-senior-official

…fficial

github-actions · 2025-03-04T21:08:03Z

🥳 Successfully deployed to developer sandbox nl.

…fficial

github-actions · 2025-03-04T23:25:44Z

🥳 Successfully deployed to developer sandbox nl.

…fficial

github-actions · 2025-03-05T23:10:59Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2025-03-05T23:20:01Z

🥳 Successfully deployed to developer sandbox nl.

…fficial

github-actions · 2025-03-06T19:16:12Z

🥳 Successfully deployed to developer sandbox nl.

…fficial

zandercymatics · 2025-03-07T14:56:41Z

Fyi - I pushed latest of this branch to bob!

zandercymatics

The senior official field isn't a select2 field on domain request for some reason so your function doesn't apply here! This actually should be one (as it was one, not sure what happened).

All you need to do to add it is to add it to the autocomplete_fields array. Double check the javascript for this field once you do this though, let me know if you run into any errors and I can assist there.

src/registrar/admin.py

src/registrar/assets/src/js/getgov-admin/andi.js

src/registrar/templates/django/admin/includes/detail_table_fieldset.html

Co-authored-by: zandercymatics <[email protected]>

…ldset.html Co-authored-by: zandercymatics <[email protected]>

…fficial

github-actions · 2025-03-07T20:26:27Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2025-03-07T20:30:41Z

🥳 Successfully deployed to developer sandbox nl.

zandercymatics

LGTM

…fficial

github-actions · 2025-03-10T16:20:11Z

🥳 Successfully deployed to developer sandbox nl.

CocoByte added 2 commits February 26, 2025 13:45

initial draft (need to fix DOM targeting)

4bcb5bf

updates

8250a72

CocoByte changed the title ~~[DRAFT] #3181 - dynamic labels for investigator and senior official~~ #3181 - dynamic labels for investigator and senior official [-Bob] Feb 27, 2025

CocoByte requested review from zandercymatics, dave-kennedy-ecs, rachidatecs, therealslimhsiehdy, Matt-Spence, erinysong and SamiyahKey and removed request for zandercymatics and dave-kennedy-ecs February 27, 2025 17:51

zandercymatics self-assigned this Feb 28, 2025

zandercymatics suggested changes Feb 28, 2025

View reviewed changes

SamiyahKey requested review from kimmsie and removed request for kimmsie February 28, 2025 17:15

CocoByte and others added 2 commits February 28, 2025 11:10

Update src/registrar/assets/src/js/getgov-admin/andi.js

8d2a247

Co-authored-by: zandercymatics <[email protected]>

resolve merge conflicts

1365272

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

5e79f98

…fficial

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

e6a4eae

…fficial

linted

c65b67d

rachidatecs reviewed Mar 4, 2025

View reviewed changes

rachidatecs self-assigned this Mar 4, 2025

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

a23a75c

…fficial

CocoByte added 3 commits March 4, 2025 11:20

Merge remote-tracking branch 'origin/nl/3181-labels-for-investigator-…

e5cee2d

…and-senior-official' into nl/3181-labels-for-investigator-and-senior-official

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

81b26d4

…fficial

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

9396600

…fficial

SamiyahKey approved these changes Mar 4, 2025

View reviewed changes

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

8def6e5

…fficial

CocoByte added 2 commits March 5, 2025 14:04

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

6b4c922

…fficial

Removed timeout (thanks Zander!), cleanup

76a660a

CocoByte requested a review from zandercymatics March 5, 2025 23:07

revert stray fixtures experiment

5c48277

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

90464b4

…fficial

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

6396d0c

…fficial

zandercymatics suggested changes Mar 7, 2025

View reviewed changes

src/registrar/admin.py Outdated Show resolved Hide resolved

src/registrar/assets/src/js/getgov-admin/andi.js Show resolved Hide resolved

src/registrar/templates/django/admin/includes/detail_table_fieldset.html Outdated Show resolved Hide resolved

CocoByte and others added 3 commits March 7, 2025 13:05

Update src/registrar/admin.py

eafafb3

Co-authored-by: zandercymatics <[email protected]>

Update src/registrar/templates/django/admin/includes/detail_table_fie…

37be432

…ldset.html Co-authored-by: zandercymatics <[email protected]>

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

c4d9d67

…fficial

restored senior_official to a select2 component

eb0f022

CocoByte requested a review from zandercymatics March 7, 2025 22:49

zandercymatics approved these changes Mar 10, 2025

View reviewed changes

Merge branch 'main' into nl/3181-labels-for-investigator-and-senior-o…

a1ca052

…fficial

CocoByte merged commit 4b11be6 into main Mar 10, 2025
8 of 10 checks passed

CocoByte deleted the nl/3181-labels-for-investigator-and-senior-official branch March 10, 2025 16:20

#3181 - dynamic labels for investigator and senior official [-Bob] #3577

#3181 - dynamic labels for investigator and senior official [-Bob] #3577

Uh oh!

Conversation

CocoByte commented Feb 27, 2025

Ticket 3181

Changes

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Ensured code standards are met (Original Developer)

Validated user-facing changes (if applicable)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Validated user-facing changes as a developer

As a designer reviewer, I have

Verified that the changes match the design intention

Validated user-facing changes as a designer

References

Screenshots

Uh oh!

zandercymatics left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2025

Uh oh!

github-actions bot commented Mar 1, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rachidatecs commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

zandercymatics commented Mar 7, 2025

Uh oh!

zandercymatics left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

zandercymatics left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

Uh oh!

Uh oh!

zandercymatics left a comment •

edited

Loading