Skip to content

Conversation

erinysong
Copy link
Contributor

@erinysong erinysong commented Oct 14, 2025

Ticket

Resolves #4127
@design: I can set up permissions for whichever designer ends up doing design review on this!

Changes

  • Add agency logos/seals to portfolios currently on production.
  • Create script that takes agency images and tries to match to corresponding agency. Suggest modifying this script or making a new one to handle static images once we host images on S3.
  • Add agency seals to Select organization page, organizations nav dropdown, and organization page

A later PR will handle:

  • Accessing agency seals on admin
  • Hosting images as media files (instead of static files) using S3 bucket for cloud and local media directory or localstack on local environments

Context for reviewers

Setup

Sandbox
On admin, assign yourself User portfolio roles to different portfolios on ES.
You should view the portfolio's organization icon on the organization select page, organization dropdown menu, and the organization page menu link.

Local

  1. Generate the static assets for the agency seals: `docker compose exec app ./manage.py collectstatic --no-input'.
  2. You will need to create Portfolio objects to get assigned the agency seal images. Create any portfolio with the same federal agency as those in stating/production.
  3. Run the script to assign the agency seal images to their corresponding portfolio: docker compose exec app ./manage.py populate_agency_seals.
  4. Verify the agency seals display on the registrar using the below screenshots.

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

  • Met the acceptance criteria, or will meet them in a subsequent PR
  • Created/modified automated tests
  • Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

  • If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
  • Interactions with external systems are wrapped in try/except
  • Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

  • Follow the process for requesting a design review. If code is not user-facing, delete design reviewer checklist
  • Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Checked keyboard navigability
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

  • Pulled this branch locally and tested it
  • Verified code meets all checks above. Address any checks that are not satisfied
  • Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
  • Checked that all code is adequately covered by tests
  • Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

  • New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Checked keyboard navigability
  • Meets all designs and user flows provided by design/product
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
  • (Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

  • Checked that the design translated visually
  • Checked behavior. Comment any found issues or broken flows.
  • Checked different states (empty, one, some, error)
  • Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

  • Checked keyboard navigability
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
  • Tested with multiple browsers (check off which ones were used)
    • Chrome
    • Microsoft Edge
    • FireFox
    • Safari
  • (Rarely needed) Tested as both an analyst and applicant user

References

Screenshots

Add agency seals to:

  • Organizations page
image
  • Organizations dropdown menu
image
  • Organization menu item
image

cryptography = "*"
rapidfuzz = "*"
httpx = "*"
pillow = "*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirement of Django ImageField

Copy link

🥳 Successfully deployed to developer sandbox es.

Copy link

🥳 Successfully deployed to developer sandbox es.

Copy link

🥳 Successfully deployed to developer sandbox es.

Copy link

🥳 Successfully deployed to developer sandbox es.

Copy link

🥳 Successfully deployed to developer sandbox es.

Copy link

🥳 Successfully deployed to developer sandbox es.

1 similar comment
Copy link

🥳 Successfully deployed to developer sandbox es.

@erinysong erinysong marked this pull request as ready for review October 16, 2025 00:12
@erinysong erinysong requested a review from a team October 16, 2025 00:13
Copy link

🥳 Successfully deployed to developer sandbox es.

@erinysong erinysong changed the title #4127: Add agency seals as static assets #4127: Add agency seals as static assets [ES] Oct 16, 2025
Copy link

🥳 Successfully deployed to developer sandbox es.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Implement agency seals for enterprise mode

1 participant