-
Notifications
You must be signed in to change notification settings - Fork 26
#4127: Add agency seals as static assets [ES] #4287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cryptography = "*" | ||
rapidfuzz = "*" | ||
httpx = "*" | ||
pillow = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requirement of Django ImageField
🥳 Successfully deployed to developer sandbox es. |
🥳 Successfully deployed to developer sandbox es. |
🥳 Successfully deployed to developer sandbox es. |
🥳 Successfully deployed to developer sandbox es. |
🥳 Successfully deployed to developer sandbox es. |
🥳 Successfully deployed to developer sandbox es. |
1 similar comment
🥳 Successfully deployed to developer sandbox es. |
… es/4127-agency-seals-static
🥳 Successfully deployed to developer sandbox es. |
🥳 Successfully deployed to developer sandbox es. |
Ticket
Resolves #4127
@design: I can set up permissions for whichever designer ends up doing design review on this!
Changes
A later PR will handle:
Context for reviewers
Setup
Sandbox
On admin, assign yourself User portfolio roles to different portfolios on ES.
You should view the portfolio's organization icon on the organization select page, organization dropdown menu, and the organization page menu link.
Local
docker compose exec app ./manage.py populate_agency_seals
.Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots
Add agency seals to: