Skip to content

Conversation

kimallen
Copy link
Contributor

@kimallen kimallen commented Oct 14, 2025

Ticket

Resolves #00

Changes

  • Fixes auth email and tenant key in cloudflareservice

Context for reviewers

I'm not sure how those test values got through. Changed it back to use the env't vars

Setup

Add a record through the prototype and ensure it can be successfully added (how to)

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

  • Met the acceptance criteria, or will meet them in a subsequent PR
  • Created/modified automated tests
  • Update documentation in READMEs and/or onboarding guide

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

  • Pulled this branch locally and tested it
  • Verified code meets all checks above. Address any checks that are not satisfied
  • Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
  • Checked that all code is adequately covered by tests
  • Verify migrations are valid and do not conflict with existing migrations

Copy link
Contributor

@erinysong erinysong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Successfully tested and submitted a DNS prototype record

Image

@kimallen kimallen merged commit 2b87938 into main Oct 16, 2025
10 checks passed
@kimallen kimallen deleted the ka/fix-cf-auth-values branch October 16, 2025 21:28
chaswick pushed a commit that referenced this pull request Oct 17, 2025
* Fix auth values from unintested test values

* Dumb comment change to trigger CI checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants