Check that file exists before attempting to move it #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packer is not preinstalled on the ubuntu-24.04 runner image, for example, so the previous code will result in an error there.
jsf9k
added
bug
dv4harr10
approved these changes
Aug 7, 2024
mcdonnnj
approved these changes
Aug 7, 2024
| @@ -115,7 +115,10 @@ jobs: | |||
| "https://releases.hashicorp.com/packer/${PACKER_VERSION}/${PACKER_ZIP}" | |||
| sudo unzip -d /opt/packer \ | |||
| ${{ env.CURL_CACHE_DIR }}/"${PACKER_ZIP}" | |||
| sudo mv /usr/local/bin/packer /usr/local/bin/packer-default | |||
| if [ -e /usr/local/bin/packer ] | |||
There was a problem hiding this comment.
Would you please backport this to cisagov/skeleton-generic? I believe this will start to be a problem as ubuntu-latest is starting to use ubuntu-24.04 with a GA this month based on actions/runner-images#9691 (comment).
|
@mcdonnnj found a |
This can be found in cisagov/skeleton-generic#187. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request modifies the GitHub workflows to verify that
/usr/local/bin/packerexists before attempting tomvit.💭 Motivation and context
Packer is not preinstalled on the
ubuntu-24.04runner image, for example, so the previous code will result in an error there.🧪 Testing
This change was tested as part of cisagov/freeipa-server-packer#133.
✅ Pre-approval checklist