This repository was archived by the owner on Apr 7, 2023. It is now read-only.
Bump package versions up in chat resource #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
useless changes. |
Contributor
blattersturm
left a comment
blattersturm
left a comment
There was a problem hiding this comment.
Sorry for the late review - would it be problematic if I verified+adapted this myself if you don't have time?
| mode: 'production', | ||
| entry: './html/main.ts', | ||
| output: { | ||
| filename: '[name].[contenthash:8].js', |
Contributor
There was a problem hiding this comment.
Having a content hash is a bit weird here... and wouldn't this break the fxmanifest.lua entry?
Author
There was a problem hiding this comment.
hi, sorry please feel free to continue this PR if you wish. I no longer work around FiveM related code :)
| setTimeout(() => { | ||
| const input = this.$refs.input as HTMLInputElement; | ||
| delete input.style.height; | ||
| input.style.height = ''; |
Contributor
There was a problem hiding this comment.
Hm - does delete not work on a style el?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the versions in the package.json of the chat resource, to keep them up to date. Some webpack updates have been added as well as some typescript config changes.