Skip to content

Commit

Permalink
Update reference table test to correct vkey value in update statement
Browse files Browse the repository at this point in the history
  • Loading branch information
m3hm3t committed Feb 13, 2025
1 parent 0f8592d commit 4c5ac75
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
14 changes: 1 addition & 13 deletions src/test/regress/expected/issue_7891.out
Original file line number Diff line number Diff line change
Expand Up @@ -3,43 +3,37 @@
-- https://github.com/citusdata/citus/issues/7891
CREATE SCHEMA issue_7891;
SET search_path TO issue_7891;

-- Create tables
CREATE TABLE t2_ref (
vkey INT,
pkey INT,
c15 TIMESTAMP
);

CREATE TABLE t4_pg (
vkey INT,
pkey INT,
c22 NUMERIC,
c23 TEXT,
c24 TIMESTAMP
);

CREATE TABLE t6_pg (
vkey INT,
pkey INT,
c26 TEXT
);

-- Mark t2_ref as a reference table
SELECT create_reference_table('t2_ref');
create_reference_table
---------------------------------------------------------------------

(1 row)


-- Insert sample data
INSERT INTO t6_pg (vkey, pkey, c26) VALUES (2, 12000, '');
INSERT INTO t4_pg (vkey, pkey, c22, c23, c24)
VALUES (5, 15000, 0.0, ']]?', MAKE_TIMESTAMP(2071, 10, 26, 16, 20, 5));
INSERT INTO t2_ref (vkey, pkey, c15)
VALUES (14, 24000, NULL::timestamp);

-- Show initial data
SELECT 't6_pg before' AS label, * FROM t6_pg;
label | vkey | pkey | c26
Expand All @@ -59,46 +53,40 @@ SELECT 't2_ref data' AS label, * FROM t2_ref;
t2_ref data | 14 | 24000 |
(1 row)


--
-- The problematic query: update t6_pg referencing t4_pg and sub-subquery on t2_ref.
-- Historically might produce a 0-task plan if the planner incorrectly fails to
-- treat t4_pg/t2_ref as local/reference.
--

-- The outer subquery iterates over every row in table t4_pg.
UPDATE t6_pg
SET vkey = 43
WHERE EXISTS (
SELECT (SELECT c15 FROM t2_ref)
FROM t4_pg
);

-- Show final data
SELECT 't6_pg after' AS label, * FROM t6_pg;
label | vkey | pkey | c26
---------------------------------------------------------------------
t6_pg after | 43 | 12000 |
(1 row)


-- The outer subquery iterates over rows from the reference table t2_ref
UPDATE t6_pg
SET vkey = 43
SET vkey = 44
WHERE EXISTS (
SELECT (SELECT c22 FROM t4_pg)
FROM t2_ref
);
ERROR: relation "issue_7891.t6_pg" does not exist
CONTEXT: while executing command on localhost:xxxxx

-- Show final data
SELECT 't6_pg after' AS label, * FROM t6_pg;
label | vkey | pkey | c26
---------------------------------------------------------------------
t6_pg after | 43 | 12000 |
(1 row)


SET client_min_messages TO WARNING;
DROP SCHEMA issue_7891 CASCADE;
2 changes: 1 addition & 1 deletion src/test/regress/sql/issue_7891.sql
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ SELECT 't6_pg after' AS label, * FROM t6_pg;

-- The outer subquery iterates over rows from the reference table t2_ref
UPDATE t6_pg
SET vkey = 43
SET vkey = 44
WHERE EXISTS (
SELECT (SELECT c22 FROM t4_pg)
FROM t2_ref
Expand Down

0 comments on commit 4c5ac75

Please sign in to comment.