Implement DROP OWNED BY propagation

[TsinghuaLucky912]

DESCRIPTION: Fixes a bug that caused DROP OWNED BY to not drop schemas on workers

Dear developers, I have submitted a version of the code to solve the problem that the DROP OWNED BY command is not delivered to the worker node, which causes the failure to create objects such as schemas again.

1. link: DROP OWNED BY fails to drop the schemas on the workers #5763
2. fix the problem DROP OWNED BY fails to drop the schemas on the workers #5763 DROP OWNED BY fails to drop the schemas on the workers

Fixes #5763

[TsinghuaLucky912]

If this is allowed, I will ban the following content in the regression test. I want to know what everyone thinks of this problem?

SELECT run_command_on_workers($$DROP OWNED BY read_access$$);
                        run_command_on_workers                        
 ---------------------------------------------------------------------
- (localhost,57637,t,"DROP OWNED")
- (localhost,57638,t,"DROP OWNED")
+ (localhost,57637,f,"ERROR:  operation is not allowed on this node")
+ (localhost,57638,f,"ERROR:  operation is not allowed on this node")
 (2 rows)

[onderkalaci]

Thanks for the contribution!

 DROP SCHEMA single_node_ent CASCADE;
 DROP OWNED BY full_access_single_node;
 DROP OWNED BY read_access_single_node;
 SELECT run_command_on_workers($$DROP OWNED BY full_access_single_node$$);
                        run_command_on_workers                        
 ---------------------------------------------------------------------
- (localhost,57637,t,"DROP OWNED")
+ (localhost,57637,f,"ERROR:  operation is not allowed on this node")
 (1 row)

I think you should also adjust the existing regression tests NOT to have SELECT run_command_on_workers($$DROP OWNED BY XXX$$); anymore

[onderkalaci]

Can you really have this? Postgres code seems to deal with only RoleSpec: https://github.com/postgres/postgres/blob/3d14e171e9e2236139e8976f3309a588bcc8683b/src/backend/commands/user.c#L1467

[TsinghuaLucky912]

@onderkalaci Thank you very much for your review, which is very helpful to me

[TsinghuaLucky912]

@onderkalaci

Hi, I would like to ask this ci/circleci: check-style — Your tests failed on CircleCI regression testing question:

FAIL: src/include/distributed/deparser.h (File size changed from 10821 to 10822)
FAIL: src/include/distributed/commands.h (File size changed from 37021 to 37033)
FAIL: src/backend/distributed/commands/owned.c (File size changed from 2503 to 2501)

This is the first time I submit code for citus, not sure what this means and how to solve it?

I took a look at the actual size of the file, but couldn't see why：

[SaitTalhaNisanci]

It means your code doesn't comply with the style standards of the project, you can follow this to fix it: https://github.com/citusdata/citus/blob/main/CONTRIBUTING.md#following-our-coding-conventions

[TsinghuaLucky912]

@SaitTalhaNisanci @onderkalaci Thank you so much for your documentation help, I performed a
Make reindent can be, CI has all passed Thank you again for your help!

[TsinghuaLucky912]

@SaitTalhaNisanci @marcocitus @onderkalaci Hello, I just updated my branch (update main) and caused some regression tests to fail, but I found no exceptions on the local environment (pg15), can you help me start CI again? thank you very much!