Add STYLEGUIDE.md on our development practices #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurctirtir
commented
Nov 15, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7347 +/- ##
==========================================
- Coverage 89.70% 89.62% -0.08%
==========================================
Files 283 283
Lines 60519 60521 +2
Branches 7544 7544
==========================================
- Hits 54286 54243 -43
- Misses 4079 4120 +41
- Partials 2154 2158 +4 |
c2main
reviewed
Nov 20, 2023
c2main
reviewed
Nov 22, 2023
gurkanindibay
previously requested changes
Nov 22, 2023
JelteF
reviewed
Dec 11, 2023
JelteF
reviewed
Dec 11, 2023
JelteF
reviewed
Dec 11, 2023
JelteF
reviewed
Dec 11, 2023
JelteF
reviewed
Dec 11, 2023
|
Let's update this and get this merged. |
JelteF
reviewed
Jan 15, 2024
JelteF
reviewed
Jan 15, 2024
JelteF
reviewed
Jan 15, 2024
onurctirtir
force-pushed
the
contributing-dev
branch
from
9f2bfc3 to
9ce4e1d
Compare
onurctirtir
dismissed
gurkanindibay’s stale review
addressed all the comments
onurctirtir
changed the title
JelteF
reviewed
Jan 31, 2024
JelteF
reviewed
Jan 31, 2024
onurctirtir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.