Fix incorrect "VALID UNTIL" assumption made for roles in node activation #7534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7534 +/- ##
==========================================
- Coverage 89.68% 89.52% -0.16%
==========================================
Files 283 283
Lines 60428 60424 -4
Branches 7525 7525
==========================================
- Hits 54194 54096 -98
- Misses 4080 4141 +61
- Partials 2154 2187 +33 |
onurctirtir
changed the title
|
Upgrade tests are still failing --need to take a closer look. |
JelteF
reviewed
Feb 26, 2024
| DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx | ||
| NOTICE: issuing SELECT worker_create_or_alter_role('user 2', 'CREATE ROLE "user 2" NOSUPERUSER NOCREATEDB NOCREATEROLE INHERIT NOLOGIN NOREPLICATION NOBYPASSRLS CONNECTION LIMIT -1 PASSWORD NULL VALID UNTIL ''infinity''', 'ALTER ROLE "user 2" NOSUPERUSER NOCREATEDB NOCREATEROLE INHERIT NOLOGIN NOREPLICATION NOBYPASSRLS CONNECTION LIMIT -1 PASSWORD NULL VALID UNTIL ''infinity''');SECURITY LABEL FOR "citus '!tests_label_provider" ON ROLE "user 2" IS 'citus ''!unclassified' | ||
| NOTICE: issuing SELECT worker_create_or_alter_role('user 2', 'CREATE ROLE "user 2" NOSUPERUSER NOCREATEDB NOCREATEROLE INHERIT NOLOGIN NOREPLICATION NOBYPASSRLS CONNECTION LIMIT -1 PASSWORD NULL', 'ALTER ROLE "user 2" NOSUPERUSER NOCREATEDB NOCREATEROLE INHERIT NOLOGIN NOREPLICATION NOBYPASSRLS CONNECTION LIMIT -1 PASSWORD NULL');SECURITY LABEL FOR "citus '!tests_label_provider" ON ROLE "user 2" IS 'citus ''!unclassified' |
There was a problem hiding this comment.
Should it maybe be VALID UNTIL NULL instead of completely removing it?
There was a problem hiding this comment.
I believe it't not valid to use NULL for valid until:
create user new_user password '12345' valid until null;
ERROR: syntax error at or near "null"
LINE 1: create user new_user password '12345' valid until null;
^There was a problem hiding this comment.
I believe it't not valid to use
NULLforvalid until:create user new_user password '12345' valid until null; ERROR: syntax error at or near "null" LINE 1: create user new_user password '12345' valid until null; ^
What do you think about this @JelteF?
There was a problem hiding this comment.
Yeah, if that syntax is invalid than obviously not.
onurctirtir
force-pushed
the
fix-valid-until-inf-assumption
branch
from
4b94673 to
1c14872
Compare
onurctirtir
changed the base branch from
main
to
check-column-existence-in-xact-recovery
onurctirtir
force-pushed
the
check-column-existence-in-xact-recovery
branch
from
b540988 to
861cc92
Compare
onurctirtir
force-pushed
the
fix-valid-until-inf-assumption
branch
from
1c14872 to
4d68745
Compare
onurctirtir
force-pushed
the
check-column-existence-in-xact-recovery
branch
from
861cc92 to
d99505f
Compare
onurctirtir
force-pushed
the
fix-valid-until-inf-assumption
branch
2 times, most recently
from
c25efdd to
4ea1960
Compare
onurctirtir
force-pushed
the
check-column-existence-in-xact-recovery
branch
from
d99505f to
b7cd28c
Compare
onurctirtir
force-pushed
the
fix-valid-until-inf-assumption
branch
from
4ea1960 to
0ba9820
Compare
onurctirtir
changed the base branch from
check-column-existence-in-xact-recovery
to
main
JelteF
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7533.
DESCRIPTION: Fixes incorrect
VALID UNTILsetting assumption made for roles when syncing them to new nodes